Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

Hi Kevin, thanks for your feedback. Please fin my comments inline. > Am 09.08.2016 um 03:10 schrieb Kevin Rushforth : > > I uploaded the patch, reviewed it, and provided comments in the bug report. > The short version is: > > * The new API looks good > > * There is a missing '@since 9' in the

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

I uploaded the patch, reviewed it, and provided comments in the bug report. The short version is: * The new API looks good * There is a missing '@since 9' in the javadoc comments along with a few typos / style issues * Rather than using reflection and setAccessible in the implementation, pl

[9, 8u] Review request: 8159726: Cleanup whitespace and file permission in tests repo

Andrey, Please review the following white-space-only change: https://bugs.openjdk.java.net/browse/JDK-8159726 http://cr.openjdk.java.net/~kcr/8159726/webrev-9.01/ With this change the openjfx tests repo in both 8u and 9 will be jcheck compliant. Thanks. -- Kevin

[9] Review request: 8163183: [test] Correct assertEquals ("", actual, expected) in LoadTest.loadJarFile

Hi Kevin & Arun, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8163183 Webrev : http://cr.openjdk.java.net/~ghb/8163183/webrev.00/ Thanks, Guru