Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-11 Thread Alexander Nyssen
Hi Kevin, attached please find a revised patch that contains the corrections you requested. The patch is now applicable to the new module structure (modues with 'javafx.' prefix). Regards, Alexander > Am 12.08.2016 um 00:00 schrieb Kevin Rushforth : > > > > Alexander Nyssen wrote: >> >> H

Re: Memory leaks on Linux with hardware renderer

2016-08-11 Thread Kevin Rushforth
To add to what Chien and Jim said, we use 1 context (ignoring Mac where glass also has a context) and N+1 drawables for N windows. We use a drawable per Window (including popup Windows used for Tooltip, ComboBox, etc), and a dummy drawable for when we are "in between" frames. The switch to the

Re: Memory leaks on Linux with hardware renderer

2016-08-11 Thread Chien Yang
Based on my recollection, this oddity (2 contexts) is because we use CALayer on Mac. We have tested in early prototype, when we did the switch from JOGL to native GL, Prism implementation on Linux works fine with a single GL context. - Chien On 8/11/2016 2:08 PM, Jim Graham wrote: It looks li

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-11 Thread Kevin Rushforth
Alexander Nyssen wrote: Hi Kevin, thanks for your feedback. Please fin my comments inline. Am 09.08.2016 um 03:10 schrieb Kevin Rushforth : I uploaded the patch, reviewed it, and provided comments in the bug report. The short version is: * The new API looks good * There is a missing '

Re: Memory leaks on Linux with hardware renderer

2016-08-11 Thread Jim Graham
It looks like we create a dummy drawable for the context and install it when we are done with the frame. This appeared in rev bbb8d2772b37, but it looks like that revision involved removing the unnecessary RenderingContext class, so we may have been doing something similar via the RenderingConte

Re: Memory leaks on Linux with hardware renderer

2016-08-11 Thread Itai
I'm sorry to see the issue could still not be reproduced on any OpenJFX team members. Meanwhile, I have noticed a user on reddit (JavaFX sub-reddit) had the same issue: https://www.reddit.com/r/JavaFX/comments/4nr2ln/memory_leak_when_calling_imageviewsettranslatex/ . However, they have managed to

[9] Review request 8163582: JavaFX browser can get stuck in an infinite loop when calling path.getTotalLength()

2016-08-11 Thread Guru Hb
Hi Kevin, Arun & Murali, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8163582 Webrev : http://cr.openjdk.java.net/~ghb/8163582/webrev.00/ RC : Merged back JDK-8090035 and added Unit test case. Thanks, Guru