Necessity of com.sun.javafx.embed.AbstractEvents

2016-09-16 Thread Alexander Nyssen
Hi Alexander Z., Kevin, while working on JDK-8143596 (FXCanvas does not forward touch gestures to embedded scene) I came across some „smell“ that I would like to discuss. That is, the information about events that is exchanged between JFXPanel/FXCanvas and the EmbeddedScene/EmbeddedStage is cur

In(Sanity) Testing Mondays

2016-09-16 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim

Re: In(Sanity) Testing Mondays

2016-09-16 Thread Kevin Rushforth
As next week is JavaOne, I won't be online during the day on Monday. Unless there is an unexpected show-stopper bug, please consider the repo to be "unlocked" at 1pm PT on Monday. -- Kevin Vadim Pakhnushev wrote: Reminder, Monday is our weekly sanity testing. You can find your testing assig

[9] Review Request:

2016-09-16 Thread Chris Bensen
Kevin, Add modules and limit modules are broken in some situations. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166172 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8166172/webrev.00/

Re: Necessity of com.sun.javafx.embed.AbstractEvents

2016-09-16 Thread Artem Ananiev
Hi, Alexander, I believe I introduced that extra abstraction layer for FX/Swing events long time ago. At that time, we thought we might eventually want to embed different components than just JavaFX, but it doesn't make any sense these days. JFXPanel and FXCanvas contain a lot of FX specific

review: @native annotations

2016-09-16 Thread David Hill
Kevin, Guru, The javac tool now provides the ability to generate native headers as needed. This removes the need to run the javah tool as a separate step in the build pipeline. The feature is enabled in javac by using the new -h option, which is used to specify a directory in which the header