Re: [9] RfR: 8169289: JavaFX application in named module fails to launch if no main method

Looks good with two minor comments: 1) It looks like the new "mainModule" parameter to launchApplicationWithArgs is only ever called with "null". Did you intend it to be called with the application module in the case of LM_MODULE? 2) In the case of LM_JAR with no preloader attribute (i.e., J

Re: [9] RfR: 8169289: JavaFX application in named module fails to launch if no main method

Ping? The OpenJDK portion is reviewed and ready to push. I'd prefer to push them at the same time so we don't have a bug that appears to be resolved when it isn't. -DrD- > Please review the JavaFX changes needed for this issue: > https://bugs.openjdk.java.net/browse/JDK-8169289 > > webrev: >

[9] Review request: JDK-8167508 ant-javafx.jar and jdk.packager runtime version check

Kevin, Please review this change to have ant-javafx.jar check the version of Java that is running it and match the version it was intended to run with by comparing against a version string that is stored in the jar file. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167508 Webrev: http://cr.o

[WebView] Single page application - relative resource in a different jar

Hi, short question from my side. I’ve submitted the following bug report which is fixed with 8u112. - [WebView] Icon font doesn't work if single page application will be loaded from jar https://bugs.openjdk.java.net/browse/JDK-8152420 I’ve tested it and I’ve found a new related one.