Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

2016-11-22 Thread Doychin Bondzhev
Hi, I think this line is incorrect: if (ver < 2 && ver > 3) { It should be || instead of && On 22.11.2016 г. 15:51 ч., Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev: http://cr.openjdk.java.net/~ssade

[9] Review request: 8170122: Packager Tests

2016-11-22 Thread Chris Bensen
Kevin, Adding Java Packager examples/tests. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170122 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170122/webrev.00/ Chris

[9] Review request for 8150175: Need replacement in FXDnD for DropTargetContext::addNotify, removeNotify

2016-11-22 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8150175/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8150175 -- Thanks, Alexander.

[9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

2016-11-22 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/ In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK version cannot be detected using the check for the

PopupWindow.AnchorLocation inconsistent with other location properties in RTL mode

2016-11-22 Thread Itai
It seems the meaning of AnchorLocation is opposite to all other position/location parameters in JavaFX when using RTL orientation: in javafx.geometry.Pos, javafx.geometry.HPos LEFT always means "start", so in RTL orientation it aligns nodes to the right (i.e. start of read order). In AnchorLocatio

Re: Problem editing FXML documents with latest SceneBuilder 8.2.0 with a"${attrname}" text property

2016-11-22 Thread Rony G. Flatscher
On 22.11.2016 10:34, Rony G. Flatscher wrote: > Not sure whether this is the correct list, if not, please advise where to > post such observations. > > The latest SceneBuilder 8.2.0 (in this case the 64-bit Windows-Version) seems > to not be able to > process 'text="${attrname}"' definitions, e.g

Problem editing FXML documents with latest SceneBuilder 8.2.0 with a"${attrname}" text property

2016-11-22 Thread Rony G. Flatscher
Not sure whether this is the correct list, if not, please advise where to post such observations. The latest SceneBuilder 8.2.0 (in this case the 64-bit Windows-Version) seems to not be able to process 'text="${attrname}"' definitions, e.g. for a Label. Such an entry will not be displayed in th