Re: 8173385: spelling errors in JavaFX javadoc

2017-01-30 Thread Jonathan Giles
I fear we might be seeing the beginning of a snowball of small javadoc cleanups :-) In any case, I have now posted a third revision to include fixes identified by Ajit, Kevin, and Jim (as well as a few of my own) here: http://cr.openjdk.java.net/~jgiles/8173385.3/ Further discussion can

Re: 8173385: spelling errors in JavaFX javadoc

2017-01-30 Thread Jim Graham
The spelling changes look right, but "of Foo method" bothers me - it should be "of the Foo method". The same comment would reply to the retainAll doc comment... :( ...jim On 1/29/17 1:31 PM, Jonathan Giles wrote: Ajit, Could you please review the following jira issue

[9] Review request: 8172950: JavaFX 9 l10n resource file update - msgdrop 30

2017-01-30 Thread Kevin Rushforth
Chris, Please review the following translation drop for JavaFX 9: https://bugs.openjdk.java.net/browse/JDK-8172950 http://cr.openjdk.java.net/~kcr/8172950/webrev.00/ I verified that the list of files is as expected, and and the list of properties in each file matches, with the exception of

[9] Review request for 8152421: After initing the modality of a non-primary stage to MODAL, closing that stage causes the primary stage to become non-resizable

2017-01-30 Thread Semyon Sadetsky
Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8152421 webrev: http://cr.openjdk.java.net/~ssadetsky/8152421/webrev.01/ Set window enabled logic is updated to restore window resizability correctly. --Semyon