[10] Code Review Request For 8133337: [Linux] Pasting HTML from Firefox does not work

2017-04-20 Thread Dipak Kumar
Hi Kevin, Please review the proposed fix. JBS: https://bugs.openjdk.java.net/browse/JDK-817 Webrev: http://cr.openjdk.java.net/~asrivastava/dipak/817/webrev.00/ Root cause and solution updated in JBS. Thanks, Dipak

Exceptions silently swallowed in DnD listeners, windows only

2017-04-20 Thread adam
Exceptions silently swallowed in DnD listeners... but only on Windows, and even in latest 1.8u121 release... This appears to be a bug?? I've written up here http://stackoverflow.com/questions/43488321/javafx-silently-swallowing-exception-raised-in-drag-listeners/43535229#43535229 Short version..

Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

2017-04-20 Thread Mandy Chung
+1 Mandy > On Apr 20, 2017, at 11:06 AM, Kevin Rushforth > wrote: > > Here is an updated webrev with a few suggested wording changes (e.g., removed > the reference to ModuleDescriptor, changed "accessible by" back to > "accessible to"). > > http://cr.openjdk.java.net/~kcr/8178015/webrev.02/

Re: [9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules

2017-04-20 Thread Kevin Rushforth
Here is an updated webrev with a few suggested wording changes (e.g., removed the reference to ModuleDescriptor, changed "accessible by" back to "accessible to"). http://cr.openjdk.java.net/~kcr/8178015/webrev.02/ Additionally, I removed the example in the FXML annotation showing the use of "