Will there be an API for creating materials?

2017-05-10 Thread Nir Lisker
It seems that currently developers can't create their own material because the abstract class Material is not designed to be subclassed, and so PhongMaterial is the only one available. Are there any plans to allow developers to subclass Material and crate their own materials? Phong is somewhat old

Re: CSS id selector with embedded dot

2017-05-10 Thread David Grieve
Fair enough. The CSS Reference Guide says " While the JavaFX CSS parser will parse valid CSS syntax, it is not a fully compliant CSS parser." Escaped characters is a case in point. On 5/10/17 11:10 AM, Doswald Michael wrote: On 5/10/17 2:02 PM, David Grieve wrote: Having an id with a dot i

Re: Corrections for Javadoc

2017-05-10 Thread Kevin Rushforth
I just filed a new issue to catch any last minute typos: https://bugs.openjdk.java.net/browse/JDK-8180070 I'll add your note to this new JBS bug. Thank you. -- Kevin Nir Lisker wrote: I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. I can't submit issues to the J

Corrections for Javadoc

2017-05-10 Thread Nir Lisker
I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. I can't submit issues to the JIRA so I'll list them here. A similar issue was https://bugs.openjdk.java.net/browse/JDK-8177341. - The following use "a Observable..." instead of "an Observable...". - javafx.beans.prop

Re: CSS id selector with embedded dot

2017-05-10 Thread Doswald Michael
On 5/10/17 2:02 PM, David Grieve wrote: > Having an id with a dot is not valid CSS syntax. > > From the spec: " An ID selector contains a "number sign" (U+0023, #) > immediately followed by the ID value, which must be an CSS identifiers." > > An identifier is defined here: > https://www.w3.org/TR

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-10 Thread Kevin Rushforth
I added the missing copyright header before pushing. I will file two new issues: one to add copyright headers to all the other package.html files (which I will do in JDK 9) and one to convert all of the package.html files to package-info.java (which I will target to 10...I don't want to make th

Re: CSS id selector with embedded dot

2017-05-10 Thread Tom Schindl
Infact '#the.button1' means id = the, cssclass = button1 So it would match Button b ...; b.setId("the"); b.getClassNames().add("button1"); Tom Von meinem iPhone gesendet > Am 10.05.2017 um 16:02 schrieb David Grieve : > > Having an id with a dot is not valid CSS syntax. > > From the spec: "

Re: CSS id selector with embedded dot

2017-05-10 Thread David Grieve
Having an id with a dot is not valid CSS syntax. From the spec: " An ID selector contains a "number sign" (U+0023, #) immediately followed by the ID value, which must be an CSS identifiers." An identifier is defined here: https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier. The tldr

CSS id selector with embedded dot

2017-05-10 Thread Jens Auer
Hi, I am working on a project which enforces unique FX Id by using a naming convention mirroring the hierarchical structure of the controls in the name, delimited by dots. So for example, we have a button "myPane.button1". I am not able to select this button in a css file. Here is an example pr

[10] Review request : JDK-8089840 : Disabled menu items are invisible with 100% contrast display settings

2017-05-10 Thread Ajit Ghaisas
Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8089840 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089840/webrev.0/ Regards, Ajit