[10] Review request: 8179673: JVM Crash in WebPage.setBackgroundColor() during webpage navigation (Non Public API)

2017-05-11 Thread Guru Hb
Hi Arun, Murali & Kevin, Please review the fix for : https://bugs.openjdk.java.net/browse/JDK-8179673 Webrev : http://cr.openjdk.java.net/~ghb/8179673/webrev.00/ Thanks, Guru

Re: MarlinFX upgrade 0.7.5

2017-05-11 Thread Laurent Bourgès
Hi Jim, Please review this updated webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-075.1/ I mainly synchronized again all my Marlin repositories and this provides an up-to-date patch in synch with Marlin2D. Changes: - Renderer (4 variants): use shared memory among AA and NonAA ren

Re: Corrections for Javadoc

2017-05-11 Thread Kevin Rushforth
Added. This is a questionable use of @see anyway. Thanks. -- Kevin Nir Lisker wrote: Add this to the list as well please: javafx.scene.image.Image's constructors: - Image(String url) - Image(String url, boolean backgroundLoading) - Image(String url, double requestedWidth, double requestedHe

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

2017-05-11 Thread Peter Levart
Hi Kevin, On 05/10/2017 03:19 AM, Kevin Rushforth wrote: inline Peter Levart wrote: Hi Kevin, On 05/02/2017 02:21 AM, Kevin Rushforth wrote: This review is being cross-posted to both openjfx-dev and jigsaw-dev. Please review the proposed fix for: https://bugs.openjdk.java.net/browse/JDK-81

Re: Corrections for Javadoc

2017-05-11 Thread Nir Lisker
Add this to the list as well please: javafx.scene.image.Image's constructors: - Image(String url) - Image(String url, boolean backgroundLoading) - Image(String url, double requestedWidth, double requestedHeight, boolean preserveRatio, boolean smooth) all have a @see annotation pointing to a priv

Re: Will there be an API for creating materials?

2017-05-11 Thread Kevin Rushforth
We don't currently plan any improvements in the area of 3D rendering. Even if we did, allowing application-defined materials would require some way for the application to provide the needed shader support for rendering such materials. -- Kevin Nir Lisker wrote: It seems that currently devel

Review Request: JDK-8179514: [macosx] Maximize button is enabled for non-resizable parent window when child window is opened

2017-05-11 Thread Avik Niyogi
Hi All, Kindly review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8179514 Webrev: http://cr.openjdk.java.net/~aniyogi/8179514/webrev.00/ With Regards, Avik Niyogi