Review Request 8176813: Mac: Failure to exit full-screen programmatically in some cases

2017-08-03 Thread Avik Niyogi
Please review the webrev below which tries to fix the issue of GetApplication processed for Null values. Any alternatives or suggestions are welcome. This fixes the issue presented by the description. https://bugs.openjdk.java.net/browse/JDK-8176813

Re: [10] RFR: JDK-8133329: Drag and Drop of files in a SwingNode fails

2017-08-03 Thread Prasanta Sadhukhan
On 8/4/2017 2:57 AM, Jim Graham wrote: I noticed a "FIXME" comment in there. Didn't we do a pass a while back and convert all of them into JBS entries? The new code simply repeats what was done for the existing Exception which is what has the "FIXME" comment so I would use this opportunity

[Review request] 8185767: Fix broken links in Javadocs

2017-08-03 Thread Jonathan Giles
Jon, Kevin and / or Phil, Please review the webrev below. It improves the JavaFX javadocs such that there are (hopefully) no bad links any longer. https://bugs.openjdk.java.net/browse/JDK-8185767 http://cr.openjdk.java.net/~jgiles/8185767/ Thanks, -- -- Jonathan

Re: [10] RFR: JDK-8133329: Drag and Drop of files in a SwingNode fails

2017-08-03 Thread Jim Graham
I noticed a "FIXME" comment in there. Didn't we do a pass a while back and convert all of them into JBS entries? The new code simply repeats what was done for the existing Exception which is what has the "FIXME" comment so I would use this opportunity to upgrade that FIXME into an actual bug e

Review request for : JDK-8092206 : TabPane renders content of all tabs even only one is active

2017-08-03 Thread Ambarish Rapte
Hi Kevin, Hi Jonathan, Request you to review the fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8092206 Webrev: http://cr.openjdk.java.net/~arapte/fx/8092206/webrev.04/ Regards, Ambarish

[10] RFR: JDK-8133329: Drag and Drop of files in a SwingNode fails

2017-08-03 Thread Prasanta Sadhukhan
Hi All, Please review a fix http://cr.openjdk.java.net/~psadhukhan/fx/8133329/webrev.00/ for issue https://bugs.openjdk.java.net/browse/JDK-8133329 More information in JBS. Regards Prasanta