Windows Build setupTools

Some people were reporting that Windows builds are difficult to setup. I think this is due to the fact that the call to setupTools in buildSrc/win.gradle is in fact not working correctly. Invoking buildSrc/genVSproperties.bat directly prints the correct properties. However adding some debugging t

[10] Review request: 8178951: "Module ... does not exist" is printed on console

Alexander, Please review my changes for fixing the issue: " 8178951: "Module ... does not exist" is printed on console" JIRA: https://bugs.openjdk.java.net/browse/JDK-8178951 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8178951/webrev.00/ --Victor

[10] Review request: 8189661: Regression of JDK-8095828 (though workaround does not work)

Alexander, Please review my changes for fixing the issue: "JDK-8189661: Regression of JDK-8095828 (though workaround does not work)" JIRA: https://bugs.openjdk.java.net/browse/JDK-8189661 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8189661/webrev.00/ --Victor

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

Sure, no problem. One quick comment is that a common way to solve this is by delegating to an implementation class, which would then be sub-classes. -- Kevin Michael Ennen wrote: I am not trying to be a burden here. I understand that you may not have time to hand-hold to this degree. I will

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

I am not trying to be a burden here. I understand that you may not have time to hand-hold to this degree. I will try and make progress, sorry for the follow up question. On Wed, Dec 20, 2017 at 2:08 PM, Michael Ennen wrote: > How can Robot call into the implementation when it is a super class of

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

How can Robot call into the implementation when it is a super class of the implementations? On Wed, Dec 20, 2017 at 2:04 PM, Kevin Rushforth wrote: > > > Michael Ennen wrote: > > I have a question about how to proceed with the Robot code. > > The base abstract Robot class is: https://github.com/

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

Michael Ennen wrote: I have a question about how to proceed with the Robot code. The base abstract Robot class is: https://github.com/brcolow/openjfx/blob/master/modules/javafx.graphics/src/main/java/javafx/scene/robot/Robot.java As you can see for each method, such as "getMouseX()" there i

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

I have a question about how to proceed with the Robot code. The base abstract Robot class is: https://github.com/brcolow/openjfx/blob/master/modules/javafx.graphics/src/main/java/javafx/scene/robot/Robot.java As you can see for each method, such as "getMouseX()" there is a "_" prefixed method whi

[8u] Review request: 8193554: Disable failing fxpackager tests on macOS until JDK-8193232 is fixed

Hi Victor, Please review the following to disable the FX packager tests that temporarily fail on macOS 10.12: https://bugs.openjdk.java.net/browse/JDK-8193554 http://cr.openjdk.java.net/~kcr/8193554/webrev.00/ Thanks. -- Kevin

[11] Review request: 8193895: Change JavaFX release version to 11

Hi Phil, Can you review the following to bump the release version in jfx-dev to 11: https://bugs.openjdk.java.net/browse/JDK-8193895 http://cr.openjdk.java.net/~kcr/8193895/webrev.00/ Thanks. -- Kevin

[10] Review request : JDK-8193494 : Add a regression test case for JDK-8183100 changeset

Hi Kevin, Ambarish, Request you to review following test addition : Issue : https://bugs.openjdk.java.net/browse/JDK-8193494 Fix for JDK 10 : http://cr.openjdk.java.net/~aghaisas/fx/8193494/webrev.0/ Regards, Ajit