JDK-8199560: Dynamic evaluation for binding.When

2018-03-13 Thread Nir Lisker
Hello, I've proposed to work on a public API for binding.When that adds capabilities for dynamic evaluation of the 'then' and 'otherwise' arguments. Any comments? https://bugs.openjdk.java.net/browse/JDK-8199560 - Nir

Re: Removal of apps/scenebuilder from OpenJFX repo

2018-03-13 Thread Kevin Rushforth
That will be a question for Gluon. -- Kevin Michael Paus wrote: How will these changes then be synchronized with the work Gluon is doing for the version distributed by them? Do they work on the same repo? Am 12.03.18 um 23:25 schrieb Kevin Rushforth: Hi Florian, By way of update, after

Re: Removal of apps/scenebuilder from OpenJFX repo

2018-03-13 Thread Michael Paus
How will these changes then be synchronized with the work Gluon is doing for the version distributed by them? Do they work on the same repo? Am 12.03.18 um 23:25 schrieb Kevin Rushforth: Hi Florian, By way of update, after thinking about this for a week (and getting some offline feedback), I

Re: Review Request: JDK-8199514: Refactor binding.When

2018-03-13 Thread Kevin Rushforth
Nir Lisker wrote: As I understand it, you have added this as a possible refactoring for BooleanConditionBuilder (but left the original in for comparison), right? Yes. I took Boolean as an example to demonstrate the approach. Since this would constitute a public API change,

Re: Review Request: JDK-8199514: Refactor binding.When

2018-03-13 Thread Nir Lisker
> > As I understand it, you have added this as a possible refactoring for > BooleanConditionBuilder (but left the original in for comparison), right? Yes. I took Boolean as an example to demonstrate the approach. Since this would constitute a public API change, I don't think it should be > done

Re: Review Request: JDK-8199514: Refactor binding.When

2018-03-13 Thread Kevin Rushforth
I took a quick look and had one comment: public class BooleanConditionBuilder2 extends ConditionBuilder { ... } As I understand it, you have added this as a possible refactoring for BooleanConditionBuilder (but left the original in for comparison), right? Since

Review Request: JDK-8199514: Refactor binding.When

2018-03-13 Thread Nir Lisker
Hi, Please review preliminary fix for: https://bugs.openjdk.java.net/browse/JDK-8199514 http://cr.openjdk.java.net/~nlisker/8199514/webrev.00/ Thanks, Nir

Re: Updating class javafx.beans.binding.When

2018-03-13 Thread Kevin Rushforth
Nir Lisker wrote: Solved the configuration issues, so I'm continuing with this. I submitted https://bugs.openjdk.java.net/browse/JDK-8199514 for the refactoring part. As mentioned before, this seems OK long as the refactoring is behavior-neutral and limited in scope. As for

Re: Updating class javafx.beans.binding.When

2018-03-13 Thread Nir Lisker
Solved the configuration issues, so I'm continuing with this. I submitted https://bugs.openjdk.java.net/browse/JDK-8199514 for the refactoring part. As for https://bugs.openjdk.java.net/browse/JDK-8089579, should it be closed as Not an Issue and a new issue created for the new API propasal, or

Re: Text mismeasured at certain Windows DPI levels

2018-03-13 Thread Kevin Rushforth
Thanks. We'll take a look. It's possible this is related to other bugs with initial sizing that were introduced with HiDPI spuport (although that wouldn't explain the continued failure at 175%). -- Kevin Chris Nahr wrote: OK, I filed a bug report with internal review ID 9052971.