Quick question:
Currently a Robot is created by calling `Application.createRobot` which
delegates
to the underlying platform-specific application class (GtkApplication,
WinApplication, etc.)
via `com.sun.glass.ui.Application.GetApplication().createRobot();`
You suggest moving this to the Toolkit
Okay, thanks for that review, Kevin.
I will take into account all of the your suggestions (and if any others
come in as well)
and report back soon.
Thanks,
Michael
On Tue, Mar 20, 2018 at 4:28 PM, Kevin Rushforth wrote:
> Hi Michael,
>
> Here is some quick feedback.
>
> I think what you have i
Hi,
I always thought the JavaFX-Codebase should be able to run with just the
java.base module but I was browsing the codebase a bit and was suprised
(or rather shocked) that even the base-module requires java.desktop.
If I get it correct this because of the java.beans (provided by the
adapters) s
I checked this as well, and even without checking you can see why this
fixes the tests (on Windows, with the PseudoPrinter).
This is a very important commit, as it fixes the automated build on
Windows, which makes it much easier to make progress without regression.
- Johan
On Wed, Mar 21, 2018 at
I'll defer to Phil on this review.
I have no concerns over the fix, and can confirm that the failing tests
now pass on my system.
-- Kevin
Laurent Bourgès wrote:
Kevin,
Please review this webrev that fixes the NPE in getMediaName():
JBS: https://bugs.openjdk.java.net/browse/JDK-8196617
web
Kevin,
Please review this webrev that fixes the NPE in getMediaName():
JBS: https://bugs.openjdk.java.net/browse/JDK-8196617
webrev: http://cr.openjdk.java.net/~lbourges/fx/fx-8196617.0/
It was tested OK on the appveyor CI that failed before the patch.
Thanks,
Laurent
