Review-Request for JDK-8208076 (display INVISIBLE_GLYPH_ID as square box on Windows)

2018-07-24 Thread Nakajima Akira
Hi. I'd like to request a review for JDK-8208076 [1] available as a PR [2] on the Github-Mirror. Thanks Akira Nakajima [1]https://bugs.openjdk.java.net/browse/JDK-8208076 [2]https://github.com/javafxports/openjdk-jfx/pull/137 -- Company: NTT Comware Corpora

Re: Review-Request for JDK-8207370

2018-07-24 Thread Kevin Rushforth
The following should work:     gradle -PFULL_TEST=true -PUSE_ROBOT=true -PUNSTABLE_TEST=true :systemTests:test You can limit it to just the Monocle tests as follows:     gradle -PFULL_TEST=true -PUSE_ROBOT=true -PUNSTABLE_TEST=true :systemTests:test --tests 'test.robot.com.sun.glass.ui.monoc

Re: Openjfx ea: error on trying to access private fields

2018-07-24 Thread fastegal
Hi Kevin, thanks for your quick answer. The relaxed permissions, which are allowed given the default '--illegal-access=permit' mode, only apply to modules that are linked into the Java runtime. Modules that are loaded on the module-path are subject to strict access controls. ahh ...

Re: Openjfx ea: error on trying to access private fields

2018-07-24 Thread Kevin Rushforth
Hi, The relaxed permissions, which are allowed given the default '--illegal-access=permit' mode, only apply to modules that are linked into the Java runtime. Modules that are loaded on the module-path are subject to strict access controls. I see three possible solutions for you: 1. Run your

Re: Review-Request for JDK-8207370

2018-07-24 Thread Johan Vos
Hi Michael, Excuse me for the simple question, but how to you enable those tests (as in: what options do you provide to gradle)? Fix looks trivial to me, but want to double check. - Johan On Mon, Jul 23, 2018 at 11:36 PM Michael Ennen wrote: > Hi, > > I'd like to request a review for JDK-82073

Re: Review Request JDK-8187100 [JavaFX] To make display Variation Selectors(SVS/IVS) on Win(VISTA-) and MacOS(10.6-)

2018-07-24 Thread Kevin Rushforth
This is being tracked here: https://bugs.openjdk.java.net/browse/JDK-8207932 As an RFE, this can be considered for openjfx12. -- Kevin On 7/5/2018 11:59 PM, Nakajima Akira wrote: Hi All. patch: https://github.com/javafxports/openjdk-jfx/pull/126 This is separated from http://mail.openjdk.

Re: Review Request Re: [PATCH] Fix bug to handle minus value glyph_id on Windows

2018-07-24 Thread Kevin Rushforth
As an FYI, this is filed in JBS as: https://bugs.openjdk.java.net/browse/JDK-8207839 and is now being reviewed. -- Kevin On 7/5/2018 8:10 PM, Nakajima Akira wrote: Hi All. I created github account today  and re-posted this patch to github. Please review the following fix: patch: https://git

Openjfx ea: error on trying to access private fields

2018-07-24 Thread fastegal
below is a small app that comes up with a button: on click it wants to access a private field (obviouly via reflection) in the button class. Due to relaxed permission constraints, that works in all java versions 9/10 without additional configuration and also with openjdk for non-fx classes. Wit

[openjfx11][RFR] 8196968: One time crash on exit in JNIEnv_::CallObjectMethod

2018-07-24 Thread Arunprasad Rajkumar
Hi, Please review the following fix, JBS: https://bugs.openjdk.java.net/browse/JDK-8196968 webrev: http://cr.openjdk.java.net/~arajkumar/8196968/webrev Root cause: From the crash log, I could see that WebCore image decoder is trying to call the Java method(through JNI) after detaching from mai

[openjfx11][RFR] 8208114: Drag and drop of text contents and URL links functionalities are broken in Webview

2018-07-24 Thread Arunprasad Rajkumar
Hi, Please review the following fix, JBS: https://bugs.openjdk.java.net/browse/JDK-8208114 Root cause: It is a regression of JDK-8199474. DataTransfer mode should be set to readonly before calling DataTransfer::types, otherwise it will return empty mime type list while doing DnD. Solution: