Review-Request for JDK-8209764

2018-08-20 Thread Michael Ennen
Hi, I'd like to request a review for JDK-8209764 available as a PR on Github: https://github.com/javafxports/openjdk-jfx/pull/155 Thanks. -- Michael Ennen

Review-Request for JDK-8209765

2018-08-20 Thread Michael Ennen
Hi, I'd like to request a review for JDK-8209765 available as a PR on Github: https://github.com/javafxports/openjdk-jfx/pull/153 Thanks. -- Michael Ennen

Re: JavaFX Deployment

2018-08-20 Thread Kevin Rushforth
I agree with this advice, too. The easiest way is to take the javafx jmods and use 'jlink' to produce the JDK you need. If your application is modularized, you can jlink your app into the java runtime image and only pull in the modules you need. If you have more advanced needs, I note that we

RE: JavaFX Deployment

2018-08-20 Thread Pedro Duque Vieira
Hi Petr, I agree with Johan, best way to distribute a JavaFX app is to bundle Java with your app. Also, not everyone as Java installed. So if you distribute just the jars so that people don't have to install anything, they might have to end up having to install Java anyway. Cheers, -- Pedro Duq

[RFR] 8207159:Update ICU to version 62.1

2018-08-20 Thread Arunprasad Rajkumar
Hi, Please review the fix for JDK-8207159. Changeset: 1. Build system related changes(done by us): http://cr.openjdk.java.net/~arajkumar/8207159/webrev 2. Complete changeset({62.1 icu + build system} changes): http://cr.openjdk.java.net/~arajkumar/8207159/webrev/icu.core.changeset.gz #1 conta

Re: JavaFX Deployment

2018-08-20 Thread Shlomo Belleli
Hi Petr This issue is a real problem for anyone that needs to deploy JavaFX and don't have the Webstart any more I am working on this issue for my own applications, and even talked with Johan about this, a few months ago there some issues here that you need to take into your consideration who are

RE: JavaFX Deployment

2018-08-20 Thread Petr Nemecek
Hi Johan, that makes sense, thanks for feedback. If I would prefer to distribute just a single jar, in order not to force users to install stuff etc., and if it will contain latest JavaFX, will it work under older Java version, which contain older version of JavaFX? Thanks, Petr

Re: JavaFX Deployment

2018-08-20 Thread Johan Vos
Hi Petr, Your questions are actually related. The recommended way for distributing JavaFX apps is by bundling them with the required libraries, modules and VM into an executable. That way, you determine whether your application works with Java 8, 9, 10, 11 or beyond. You simply bundle the required