Re: JavaFX in-memory dynamic CSS file editing and applying

2018-10-15 Thread Matthieu BROUILLARD
If what you want is to be able to test CSS changes on the fly on a running javafx application during development for example; then you can also have a look at CSSFX (https://github.com/McFoggy/cssfx). If you do not want to setup CSSFX on your own, it has been integrated inside Jonathan Giles "Sceni

Re: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

2018-10-15 Thread Kevin Rushforth
A good question. In this case it is intended to match the ImageView::smooth property, which is a boolean. If there is a need later that more than one value is needed we would have to add a new enum attribute that would take effect if imageSmooth==true, but that would be the case for any of the

Re: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

2018-10-15 Thread Kevin Rushforth
Yes, it should be "isImageSmoothing", thanks for catching this! This looks good to me to other than that. The only other comment is that when you write the docs, make sure you indicate that this applies to drawImage calls, both in the docs of the new setImageSmooth method, and in the docs of t

Re: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

2018-10-15 Thread Nir Lisker
> > public void setImageSmoothing(boolean imageSmoothing) {} to enable or > disable smoothing. A bit of forward thinking here. Will there always be only 2 ways of doing smoothing: "on" or "off"? If there will be different algorithms for smoothing, will they be set separately by "setSmoothingAlgor

Re: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

2018-10-15 Thread Dan Howard
Shouldn't it be "is" rather than "get" for boolean?  Other than that, sounds good! On 10/15/2018 3:29 PM, Ambarish Rapte wrote: Hi All, This email is for discussion regarding the fix https://bugs.openjdk.java.net/browse/JDK-8204060 . Issue: Images drawn using javafx.scene.canvas

Re: JavaFX in-memory dynamic CSS file editing and applying

2018-10-15 Thread Ty Young
On 10/15/18 7:02 AM, David Grieve wrote: Just setStyle -fx-theme-header (etc.) on the root node. That doesn't work, sadly. The actual FX CSS properties that utilize -fx-theme-header don't update after setting a new value. On 10/15/18 1:05 AM, Ty Young wrote: Does JavaFX have an API for

Re: Java-FX 11. Missing toolkit? Error initializing QuantumRenderer

2018-10-15 Thread Andrew Munn
Thanks Kevin. It was missing .so files. On Mon, 15 Oct 2018, Kevin Rushforth wrote: > There is no more jfxrt.jar as of JDK 9, so no, that isn't the problem. It > looks like it can't load the native libraries. Two things to try to get more > information: > > 1. Run with "-Dprism.verbose=true"

Re: Java-FX 11. Missing toolkit? Error initializing QuantumRenderer

2018-10-15 Thread Kevin Rushforth
There is no more jfxrt.jar as of JDK 9, so no, that isn't the problem. It looks like it can't load the native libraries. Two things to try to get more information: 1. Run with "-Dprism.verbose=true" and "-Djavafx.verbose=true" and see if that gives a better error message. 2. Check to see tha

Java-FX 11. Missing toolkit? Error initializing QuantumRenderer

2018-10-15 Thread Andrew Munn
I'm using x2go to connect to a session running the Mate window manager and seein this error. Could it be related to a missing jfxrt.jar? I don't see that jar under /opt/javafx-sdk-11 I'm starting my application with these: --add-opens javafx.fxml/javafx.fxml=ALL-UNNAMED" --illegal-access=perm

Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

2018-10-15 Thread Ambarish Rapte
Hi All, This email is for discussion regarding the fix https://bugs.openjdk.java.net/browse/JDK-8204060 . Issue: Images drawn using javafx.scene.canvas .GraphicsContext::drawImage() always apply filtering to the image. Solution: javafx.scene.canvas.GraphicsContext should provide an

Re: 3D Canvas Node?

2018-10-15 Thread John-Val Rose
I also believe that such a component would be highly beneficial & I myself have suggested it many times in the past. To Chengen Zhao, you may not be aware but there is a new mailing list where it may be more appropriate to ask this question. That list is openjfx-disc...@openjdk.java.net I hope

RE: JavaFX in-memory dynamic CSS file editing and applying

2018-10-15 Thread Pedro Duque Vieira
Not sure if I totally understand what you want but you can change the values of CSS variables through code by setting inline styles on components, via setStyle method. Pardon the publicity but yesterday I just happened to mention exactly that on one of my posts and might help you: https://pixelduk

Backport for https://bugs.openjdk.java.net/browse/JDK-8157913 to jdk8?

2018-10-15 Thread Robert Lichtenberger
Is there a chance that the fix for https://bugs.openjdk.java.net/browse/JDK-8157913 will be backported to jdk8? It seems like a major error to me, if packaged applications don't start and I have just been affected by this problem. Best regards, Robert Lichtenberger

Re: Review request for #151 Open VirtualFlow and other relating classes API for sublclassing

2018-10-15 Thread Kevin Rushforth
Samir, Also, can you provide JBS bug ID? The one you listed in your review request is the wrong Bug ID. Thanks. -- Kevin On 10/15/2018 6:00 AM, Kevin Rushforth wrote: Note that since this is request for a new feature there are a couple other steps needed: 1. The proposed feature, along w

Re: Review request for #151 Open VirtualFlow and other relating classes API for sublclassing

2018-10-15 Thread Kevin Rushforth
Note that since this is request for a new feature there are a couple other steps needed: 1. The proposed feature, along with the new API should be discussed and general agreement reached. This is already in progress and is happening in the PR itself. Mainly what needs to be ironed out now is t

3D Canvas Node?

2018-10-15 Thread Chengen Zhao
Hi: We are currently developing games by using JavaFX one feature would be nice to have is 3D Canvas node so is it possible to have this feature in the future release? Thanks

Review request for #151 Open VirtualFlow and other relating classes API for sublclassing

2018-10-15 Thread Sam'
Please review the GitHub pull request: https://github.com/javafxports/openjdk-jfx/pull/163 which fixes: Open VirtualFlow API for subclassing https://github.com/javafxports/openjdk-jfx/issues/151

Re: JavaFX in-memory dynamic CSS file editing and applying

2018-10-15 Thread David Grieve
Just setStyle -fx-theme-header (etc.) on the root node. On 10/15/18 1:05 AM, Ty Young wrote: Does JavaFX have an API for dynamically editing and applying CSS files in-memory? If not, would there be any possibility in one ever being made? My reasoning for such an API is, instead of switching

Re: Some visual issues with a test application

2018-10-15 Thread Mark Raynsford
Hello! On 2018-10-14T23:36:37 -0500 Ty Young wrote: > > but I digress, JDK 11 switched to GTK3 by default which has caused some > bugs. Try setting: > > > -Djdk.gtk.version=2 This fixes the menu issue (thanks!) but it doesn't fix the issue with the icons in the table. Is there an open bug for