Re: Review request backport 8210386

2018-10-29 Thread Laurent Bourgès
Thank you, Laurent Le lun. 29 oct. 2018 à 19:35, Kevin Rushforth a écrit : > Looks good. Approved for pushing to 11-dev. > > -- Kevin > > On 10/29/2018 11:27 AM, Johan Vos wrote: > > new webrev including test: > > http://cr.openjdk.java.net/~jvos/8210386/webrev.01/ > >

Re: Review request backport 8210386

2018-10-29 Thread Kevin Rushforth
Looks good. Approved for pushing to 11-dev. -- Kevin On 10/29/2018 11:27 AM, Johan Vos wrote: new webrev including test: http://cr.openjdk.java.net/~jvos/8210386/webrev.01/ On Mon, Oct 29, 2018 at 5:55 PM Kevin Rushforth mailto:kevin.r

Re: Review request backport 8210386

2018-10-29 Thread Johan Vos
new webrev including test: http://cr.openjdk.java.net/~jvos/8210386/webrev.01/ On Mon, Oct 29, 2018 at 5:55 PM Kevin Rushforth wrote: > The newly added test, which was pushed to jfx-dev as part of the fix for > 12, is missing from the webrev:

Re: Review request backport 8210386

2018-10-29 Thread Kevin Rushforth
The newly added test, which was pushed to jfx-dev as part of the fix for 12, is missing from the webrev: tests/system/src/test/java/test/com/sun/marlin/ScaleClipTest.java The rest looks OK. -- Kevin On 10/29/2018 9:39 AM, Johan Vos wrote: Hi Kevin, Please review the backport of 8210386 (Ma

Review request backport 8210386

2018-10-29 Thread Johan Vos
Hi Kevin, Please review the backport of 8210386 (Marlin fixes) into 11-dev (target 11.0.1) http://cr.openjdk.java.net/~jvos/8210386/webrev.00/ - Johan

[11] RFR: JDK-8213047: Change JavaFX release version in 11-dev to 11.0.1

2018-10-29 Thread Kevin Rushforth
Hi Johan, I request approval to push this fix to 11-dev. Please review the following fix to bump the release version for FX 11-dev to 11.0.1 in preparation for 11.x builds: https://bugs.openjdk.java.net/browse/JDK-8213047 http://cr.openjdk.java.net/~kcr/8213047/webrev/ -- Kevin