Re: Why cannot run compiled JavaFX 11 class?

2018-10-30 Thread Murray Eisenberg
But the run command I gave, ending in just “HelloFX”, is exactly what was shown at https://openjfx.io/openjfx-docs/#install-javafx. What exactly is it that I’d have to enter instead? (I did try adding extension “.class” but that didn’t help.) > On 30 Oct2018, at 5:17 PM, Steve Hannah wrote:

Re: JDK-8090930: Add Support for Extended Mouse Buttons

2018-10-30 Thread Kevin Rushforth
I don't have a strong opinion. On the one hand, the platform libraries (at least Mac and Windows) use some variation of BUTTON4 and BUTTON5 rather than a name. On the other hand, we already use symbolic names for the PRIMARY, SECONDARY, and MIDDLE buttons, rather than using 1, 2, 3. I'm OK with

Re: Why cannot run compiled JavaFX 11 class?

2018-10-30 Thread Steve Hannah
The "java" command expects a fully-qualified class name, not a file path as its argument. E.g. cd /Users/me/Documents/java java --module-path $PATH_TO_FX --add-modules=javafx.controls HelloFX On Tue, Oct 30, 2018 at 2:06 PM Murray Eisenberg wrote: > This is under macOS Mojave (10.14). > > Fo

Why cannot run compiled JavaFX 11 class?

2018-10-30 Thread Murray Eisenberg
This is under macOS Mojave (10.14). Following instructions at https://openjfx.io/openjfx-docs/#install-javafx, I compiled the sample HelloFX.java via: javac --module-path $PATH_TO_FX --add-modules=javafx.controls /Users/me/Documents/java/HelloFX.java But now if I attempt to run that...

Re: JDK-8090930: Add Support for Extended Mouse Buttons

2018-10-30 Thread Michael Ennen
Great question. It seems to be pretty standard that mouse buttons 4 and 5 are called back and forward. So either way would be fine with me. In my opinion the descriptive names may be better as then EventListeners responding to these new buttons would be more human-readable. On Tue, Oct 30, 2018 at

[RFR] [12] JDK-8207772: File API and FileReader should be supported in WebView

2018-10-30 Thread Murali Billa
  Hi Kevin, Johan, Arun, Please review the below enhancement for File Reader support in JavaFX WebView. JIRA: https://bugs.openjdk.java.net/browse/JDK-8207772   Github PR: https://github.com/javafxports/openjdk-jfx/pull/250   Thanks, Murali

Re: JDK-8090930: Add Support for Extended Mouse Buttons

2018-10-30 Thread Johan Vos
Hi Michael, I only started to look into this now, sorry for being late at the party. Overall, this looks good to me. The risk is indeed minimal (developers relying on switch-default cases to select e.g. middle button will be punished). I am not entirely sure about the naming though. Should it rea