Review Request: JDK-8217270: Broken link to cssref.html in javafx.controls package docs

2019-01-16 Thread Nir Lisker
Hi, Please review the simple fix for: https://bugs.openjdk.java.net/browse/JDK-8217270 http://cr.openjdk.java.net/~nlisker/8217270/webrev.00/ Thanks, Nir

Re: JavaFX Content Rendering & Resizing and Font Bugs In Linux

2019-01-16 Thread Ty Young
On 1/16/19 8:57 AM, Siddhesh Rane wrote: January 16, 2019 8:07 AM, "Ty Young" wrote: ...and can cause undefined behavior like horizontal scrollbars showing when they shouldn't I assume? As I have said previously, scrollbar issue is occuring only due to your use of DoubleBinding in layout.

Re: Review request for [JDK-8217259] release notes 11.0.2

2019-01-16 Thread Kevin Rushforth
Approved. -- Kevin On 1/16/2019 7:06 AM, Johan Vos wrote: Hi Kevin, Please review http://cr.openjdk.java.net/~jvos/8217259/webrev.00/ which contains the release notes for 11.0.2 A layouted version of this is also available at https://github.com/johanvos/openjdk-jfx/blob/jfx-11/doc-files/rel

Review request for [JDK-8217259] release notes 11.0.2

2019-01-16 Thread Johan Vos
Hi Kevin, Please review http://cr.openjdk.java.net/~jvos/8217259/webrev.00/ which contains the release notes for 11.0.2 A layouted version of this is also available at https://github.com/johanvos/openjdk-jfx/blob/jfx-11/doc-files/release-notes-11.0.2.md Thanks, - Johan

Re: JavaFX Content Rendering & Resizing and Font Bugs In Linux

2019-01-16 Thread Siddhesh Rane
January 16, 2019 8:07 AM, "Ty Young" wrote: > > ...and can cause undefined behavior like horizontal scrollbars showing when > they shouldn't I > assume? As I have said previously, scrollbar issue is occuring only due to your use of DoubleBinding in layout. I saw your code and I can confirm th

[12] RFR: JDK-8212102: [TextField] IOOBE on paste/replace text with control characters

2019-01-16 Thread Ambarish Rapte
Hi Kevin, Ajit, Please review this fix: JBS: https://bugs.openjdk.java.net/browse/JDK-8212102 Webrev: http://cr.openjdk.java.net/~arapte/fx/8212102/webrev.00/ Regards, Ambarish

RFR 8215702: SVG gradients are not rendered

2019-01-16 Thread Arunprasad Rajkumar
Hi, Please review the following PR related to JDK-8215702, https://github.com/javafxports/openjdk-jfx/pull/347 https://bugs.openjdk.java.net/browse/JDK-8215702 Thanks, Arun