Re: RFR: 8225571: Port DND source to use GTK instead of GDK

2019-10-04 Thread Kevin Rushforth
On Wed, 2 Oct 2019 20:02:22 GMT, Kevin Rushforth wrote: > On Wed, 2 Oct 2019 19:54:50 GMT, Thiago Milczarek Sayao > wrote: > >> On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote: >> >>> On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao >>> wrote: >>> https://bugs.openjdk.j

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-04 Thread Kevin Rushforth
On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: > Allright, this is a fix for JDK-8207957 > > > > Commits: > - 969ebb51: Fixing TableColumnHeaderTest > - 9d379619: Removing Tablecolumnbasehelper > - 4fe020fc: Fix javadoc for TableColumnHeader > - c422c80f: Minor modifi

RE: Custom Fonts in User Agent Stylesheets

2019-10-04 Thread David Grieve
This seems like a bug. Certainly overriding Region#getUserAgentStylesheet() is the preferred way of customizing styles for a control. Maybe the styles from the Region UA stylesheet aren’t being considered when doing a font lookup. That would for sure be a bug. But there are a lot of moving par

Re: [Integrated] RFR: 8231854: Change Mercurial to git in various README files

2019-10-04 Thread duke
Changeset: c6eb0918 Author:Kevin Rushforth Date: 2019-10-04 12:59:35 + URL: https://git.openjdk.java.net/jfx/commit/c6eb0918 8231854: Change Mercurial to git in various README files Reviewed-by: ghb ! apps/samples/Ensemble8/UPDATING-lucene.txt ! modules/javafx.media/src/main/

Re: [Approved] RFR: 8231854: Change Mercurial to git in various README files

2019-10-04 Thread Guru Hb
On Thu, 3 Oct 2019 23:15:56 GMT, Kevin Rushforth wrote: > https://bugs.openjdk.java.net/browse/JDK-8231854 > > Follow-on fix to > [JDK-8231590](https://bugs.openjdk.java.net/browse/JDK-8231590) -- PR #3 -- > to change Mercurial or hg to git in a few README files where appropriate. > > ---

Re: RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-04 Thread Kevin Rushforth
There is no longer a need to manually send RFR emails. Once your OCA status has been re-confirmed and entered into the Skara configuration, which is a one-time step, the Skara bot will send the RFR. Until then, we cannot review it. Thank you for your patience. -- Kevin On 10/4/2019 1:43 AM,

Custom Fonts in User Agent Stylesheets

2019-10-04 Thread Dirk Lemmermann
I noticed today that the custom fonts I defined in a user agent stylesheet of a custom control are not being used. It only started working when I “manually” added the stylesheet to the control via getStylesheets().add() instead of overriding getUserAgentStylesheet(). Does anyone know if this i

Subject: RFR: 8087980: Add property to disable Monocle cursor

2019-10-04 Thread Dell Green
Please review the fix for Add property to disable Monocle cursor: https://bugs.openjdk.java.net/browse/JDK-8087980 https://github.com/openjdk/jfx/pull/5

RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-04 Thread Dell Green
Please review the fix for Updated armv6hf crosslibs script with new domains: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8231870 https://github.com/openjdk/jfx/pull/8