Re: [Approved] RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-10-29 Thread Phil Race
On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: > This PR updates the header files we use the build the OpenGL ES2 pipeline to > Mesa 19.2.1. See [this review > thread](https://mail.openjdk.java.net/pipermail/2d-dev/2019-October/010372.html) > for the equivalent change that is under

Re: RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-10-29 Thread Phil Race
On Wed, 30 Oct 2019 00:43:08 GMT, Sergey Bylokhov wrote: > On Tue, 29 Oct 2019 23:05:46 GMT, Kevin Rushforth wrote: > >> On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: >> >>> This PR updates the header files we use the build the OpenGL ES2 pipeline >>> to Mesa 19.2.1. See [this

Re: RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-10-29 Thread Sergey Bylokhov
On Tue, 29 Oct 2019 23:05:46 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: > >> This PR updates the header files we use the build the OpenGL ES2 pipeline to >> Mesa 19.2.1. See [this review >>

RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-10-29 Thread Kevin Rushforth
This PR updates the header files we use the build the OpenGL ES2 pipeline to Mesa 19.2.1. See [this review thread](https://mail.openjdk.java.net/pipermail/2d-dev/2019-October/010372.html) for the equivalent change that is under review for Java2D. The updates to the `gl.h` and `glx.h` files are

Re: RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-10-29 Thread Kevin Rushforth
On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: > This PR updates the header files we use the build the OpenGL ES2 pipeline to > Mesa 19.2.1. See [this review > thread](https://mail.openjdk.java.net/pipermail/2d-dev/2019-October/010372.html) > for the equivalent change that is under

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-10-29 Thread Florian Kirmaier
On Tue, 29 Oct 2019 15:59:58 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 15:48:46 GMT, Florian Kirmaier > wrote: > >> On Tue, 29 Oct 2019 14:47:19 GMT, Kevin Rushforth wrote: >> >>> On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth wrote: >>> On Tue, 29 Oct 2019 11:27:35 GMT,

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-10-29 Thread Kevin Rushforth
On Tue, 29 Oct 2019 15:48:46 GMT, Florian Kirmaier wrote: > On Tue, 29 Oct 2019 14:47:19 GMT, Kevin Rushforth wrote: > >> On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth wrote: >> >>> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier >>> wrote: >>> Original PR:

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-10-29 Thread Florian Kirmaier
On Tue, 29 Oct 2019 14:47:19 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth wrote: > >> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier >> wrote: >> >>> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 >>> >>> A side effect of JDK-8200224

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-10-29 Thread Kevin Rushforth
On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier > wrote: > >> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 >> >> A side effect of JDK-8200224 is, that the first click on a JFXPanel is >> always a double click.

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-10-29 Thread Kevin Rushforth
On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier wrote: > Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 > > A side effect of JDK-8200224 is, that the first click on a JFXPanel is always > a double click. > The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-29 Thread Nir Lisker
On Wed, 9 Oct 2019 16:18:49 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir wrote: > >> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: >> >>> The pull request has been updated with additional changes. >>> >>> >>> >>> Added commits: >>> -

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-29 Thread Hadzic Samir
On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth wrote: > On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Samir wrote: > >> On Mon, 7 Oct 2019 10:22:11 GMT, Jeanette Winzenburg >> wrote: >> >>> On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote: >>> Allright, this is a fix for JDK-8207957

Re: RFR: 8087980: Add property to disable Monocle cursor

2019-10-29 Thread Kevin Rushforth
On Tue, 29 Oct 2019 10:10:32 GMT, Dell Green wrote: > On Tue, 29 Oct 2019 09:53:28 GMT, Johan Vos wrote: > >> On Tue, 8 Oct 2019 12:03:46 GMT, Kevin Rushforth wrote: >> >>> On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green >>> <12861109+dellgr...@users.noreply.github.com> wrote: >>> Often

RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-10-29 Thread Florian Kirmaier
Original PR: https://github.com/javafxports/openjdk-jfx/pull/591 A side effect of JDK-8200224 is, that the first click on a JFXPanel is always a double click. The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on Menu in JFXPanel ignored if another swing component has focus). This

Re: RFR: 8087980: Add property to disable Monocle cursor

2019-10-29 Thread Dell Green
On Tue, 29 Oct 2019 09:53:28 GMT, Johan Vos wrote: > On Tue, 8 Oct 2019 12:03:46 GMT, Kevin Rushforth wrote: > >> On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green >> <12861109+dellgr...@users.noreply.github.com> wrote: >> >>> Often on embedded systems a cursor is not a valid input modality. On

Re: [Integrated] RFR: 8232943: Gesture support is not initialized on iOS

2019-10-29 Thread Johan Vos
Changeset: dca8df4e Author:Jose Pereda Committer: Johan Vos Date: 2019-10-29 10:03:54 + URL: https://git.openjdk.java.net/jfx/commit/dca8df4e 8232943: Gesture support is not initialized on iOS Reviewed-by: jvos !

Re: RFR: 8087980: Add property to disable Monocle cursor

2019-10-29 Thread Johan Vos
On Tue, 8 Oct 2019 12:03:46 GMT, Kevin Rushforth wrote: > On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green > <12861109+dellgr...@users.noreply.github.com> wrote: > >> Often on embedded systems a cursor is not a valid input modality. On some of >> these systems, when the javafx toolkit initialises

Re: [Approved] RFR: 8232943: Gesture support is not initialized on iOS

2019-10-29 Thread Johan Vos
On Fri, 25 Oct 2019 09:29:16 GMT, Jose Pereda wrote: > This PR only affects iOS native code. > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8232943 > > Since the `IosGestureSupport` class is only instantiated from the native > side, the proposal is to change in