Re: [Approved] RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-10-30 Thread Phil Race
On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: > This PR updates the header files we use the build the OpenGL ES2 pipeline to > Mesa 19.2.1. See [this review > thread](https://mail.openjdk.java.net/pipermail/2d-dev/2019-October/010372.html) > for the equivalent change that is under r

Re: [Rev 01] RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-10-30 Thread Kevin Rushforth
The pull request has been updated with additional changes. Added commits: - 5686a382: Update third-party license file to remove unneeded lines Changes: - all: https://git.openjdk.java.net/jfx/pull/26/files - new: https://git.openjdk.java.net/jfx/pull/26/files/7a520adc..5686

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-30 Thread Hadzic Samir
On Wed, 30 Oct 2019 13:59:08 GMT, Hadzic Samir wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/6/files >

Re: [Rev 04] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-30 Thread Hadzic Samir
The pull request has been updated with additional changes. Added commits: - 2b088993: Add @implSpec tag for javadoc of TableColumnHeader Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new: https://git.openjdk.java.net/jfx/pull/6/files/1f1f7c44..2b088993 We

Re: RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-10-30 Thread Kevin Rushforth
On Wed, 30 Oct 2019 11:09:38 GMT, Hadzic Samir wrote: > On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph > wrote: > >> In the HTMLEditor, when positioning the caret in a text and trying to set a >> font-family that has a number in it is not working. >> >> Issue: In >> [CSSPropertyParser.cpp](h

Re: RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-10-30 Thread Hadzic Samir
On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph wrote: > In the HTMLEditor, when positioning the caret in a text and trying to set a > font-family that has a number in it is not working. > > Issue: In > [CSSPropertyParser.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/ma

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-30 Thread Nir Lisker
On Wed, 30 Oct 2019 10:27:28 GMT, Hadzic Samir wrote: > On Tue, 29 Oct 2019 14:38:10 GMT, Nir Lisker wrote: > >> On Wed, 9 Oct 2019 16:18:49 GMT, Kevin Rushforth wrote: >> >>> On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir wrote: >>> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote:

Re: [Rev 01] RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-30 Thread Hadzic Samir
On Tue, 29 Oct 2019 14:38:10 GMT, Nir Lisker wrote: > On Wed, 9 Oct 2019 16:18:49 GMT, Kevin Rushforth wrote: > >> On Wed, 9 Oct 2019 16:11:49 GMT, Hadzic Samir wrote: >> >>> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote: >>> The pull request has been updated with additional chan

RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-10-30 Thread Arun Joseph
In the HTMLEditor, when positioning the caret in a text and trying to set a font-family that has a number in it is not working. Issue: In [CSSPropertyParser.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSPropertyParser.cpp), conca