Re: RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors

2019-11-05 Thread Robin Westberg
On Wed, 6 Nov 2019 05:07:56 GMT, Kevin Rushforth wrote: > On Wed, 6 Nov 2019 05:04:28 GMT, Kevin Rushforth wrote: > >> On Tue, 5 Nov 2019 18:10:57 GMT, Nir Lisker wrote: >> >>> https://bugs.openjdk.java.net/browse/JDK-8229472 >>> >>> CSR will be created after the changes are approved. >>>

Re: RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors

2019-11-05 Thread Kevin Rushforth
On Wed, 6 Nov 2019 05:04:28 GMT, Kevin Rushforth wrote: > On Tue, 5 Nov 2019 18:10:57 GMT, Nir Lisker wrote: > >> https://bugs.openjdk.java.net/browse/JDK-8229472 >> >> CSR will be created after the changes are approved. >> >> >> >> Commits: >> - 6d29e034: Initial push of

Re: RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors

2019-11-05 Thread Kevin Rushforth
On Tue, 5 Nov 2019 18:10:57 GMT, Nir Lisker wrote: > https://bugs.openjdk.java.net/browse/JDK-8229472 > > CSR will be created after the changes are approved. > > > > Commits: > - 6d29e034: Initial push of 8229472 > > Changes: https://git.openjdk.java.net/jfx/pull/30/files >

Re: RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors

2019-11-05 Thread Kevin Rushforth
On Tue, 5 Nov 2019 18:10:57 GMT, Nir Lisker wrote: > https://bugs.openjdk.java.net/browse/JDK-8229472 > > CSR will be created after the changes are approved. > > > > Commits: > - 6d29e034: Initial push of 8229472 > > Changes: https://git.openjdk.java.net/jfx/pull/30/files >

Re: RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors

2019-11-05 Thread Kevin Rushforth
On Tue, 5 Nov 2019 18:16:55 GMT, Nir Lisker wrote: > On Tue, 5 Nov 2019 18:10:57 GMT, Nir Lisker wrote: > >> https://bugs.openjdk.java.net/browse/JDK-8229472 >> >> CSR will be created after the changes are approved. >> >> >> >> Commits: >> - 6d29e034: Initial push of

Re: RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors

2019-11-05 Thread Nir Lisker
On Tue, 5 Nov 2019 18:10:57 GMT, Nir Lisker wrote: > https://bugs.openjdk.java.net/browse/JDK-8229472 > > CSR will be created after the changes are approved. > > > > Commits: > - 6d29e034: Initial push of 8229472 > > Changes: https://git.openjdk.java.net/jfx/pull/30/files >

RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors

2019-11-05 Thread Nir Lisker
https://bugs.openjdk.java.net/browse/JDK-8229472 CSR will be created after the changes are approved. Commits: - 6d29e034: Initial push of 8229472 Changes: https://git.openjdk.java.net/jfx/pull/30/files Webrev: https://webrevs.openjdk.java.net/jfx/30/webrev.00 Issue:

Re: JDK-8130738 TextFlow's tab width is static

2019-11-05 Thread Scott Palmer
I finally had a moment to get back at this. I've changed the name of the property from tabWidth to tabSize and implemented the CSS property '-fx-tab-size'. The CSS documentation will need to be updated. I didn't see where the CSS document is located in the source tree. While adding CSS support

Re: [Rev 01] RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists

2019-11-05 Thread Jeanette Winzenburg
The pull request has been updated with additional changes. Added commits: - fdf97072: added copyright headers Changes: - all: https://git.openjdk.java.net/jfx/pull/15/files - new: https://git.openjdk.java.net/jfx/pull/15/files/93556393..fdf97072 Webrevs: - full:

Re: [Rev 01] RFR: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene

2019-11-05 Thread Jeanette Winzenburg
The pull request has been updated with additional changes. Added commits: - 0366a0a5: added copyright header Changes: - all: https://git.openjdk.java.net/jfx/pull/20/files - new: https://git.openjdk.java.net/jfx/pull/20/files/aabea139..0366a0a5 Webrevs: - full:

Re: [Integrated] RFR: 8233040: Fix: ComboBoxPopupControl - remove eventFilter for F4

2019-11-05 Thread Ajit Ghaisas
Changeset: f74f3afb Author:Jeanette Winzenburg Committer: Ajit Ghaisas Date: 2019-11-05 12:08:33 + URL: https://git.openjdk.java.net/jfx/commit/f74f3afb 8233040: ComboBoxPopupControl: remove eventFilter for F4 Reviewed-by: aghaisas !

Re: [Integrated] RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-11-05 Thread Kevin Rushforth
Changeset: a1cc4ab0 Author:Kevin Rushforth Date: 2019-11-05 11:27:22 + URL: https://git.openjdk.java.net/jfx/commit/a1cc4ab0 8232210: Update Mesa 3-D Headers to version 19.2.1 Reviewed-by: prr, arapte ! modules/javafx.graphics/src/main/legal/mesa3d.md -

Re: [Rev 01] RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-11-05 Thread Arun Joseph
The pull request has been updated with additional changes. Added commits: - afc7f17a: Minor formatting Changes: - all: https://git.openjdk.java.net/jfx/pull/27/files - new: https://git.openjdk.java.net/jfx/pull/27/files/5a1fbade..afc7f17a Webrevs: - full:

Re: [Approved] RFR: 8233040: ComboBoxPopupControl: remove eventFilter for F4

2019-11-05 Thread Ajit Ghaisas
On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg wrote: > https://bugs.openjdk.java.net/browse/JDK-8233040 > > The issue is that the eventFilter in CBPC uses F4 for toggling the popup > _and_ consumes it. This prevents client code to register there own filter. > > The fix was to remove

Re: RFR: 8233040: ComboBoxPopupControl: remove eventFilter for F4

2019-11-05 Thread Ajit Ghaisas
On Tue, 5 Nov 2019 10:38:24 GMT, Jeanette Winzenburg wrote: > On Mon, 4 Nov 2019 12:46:57 GMT, Ajit Ghaisas wrote: > >> On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg >> wrote: >> >>> https://bugs.openjdk.java.net/browse/JDK-8233040 >>> >>> The issue is that the eventFilter in CBPC

Re: RFR: WIP: 8230231: font-family not updated in HTMLEditor

2019-11-05 Thread Arun Joseph
On Tue, 5 Nov 2019 09:26:56 GMT, Arun Joseph wrote: > On Thu, 10 Oct 2019 14:56:19 GMT, Hadzic Samir wrote: > >> On Thu, 10 Oct 2019 12:19:18 GMT, Kevin Rushforth wrote: >> >>> On Thu, 10 Oct 2019 09:12:57 GMT, Hadzic Samir wrote: >>> On Wed, 9 Oct 2019 20:09:58 GMT, Kevin Rushforth

Re: [Approved] RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-11-05 Thread Kevin Rushforth
On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph wrote: > In the HTMLEditor, when positioning the caret in a text and trying to set a > font-family that has a number in it is not working. > > Issue: In >

Re: RFR: 8230492: font-family not set in HTMLEditor if font name has a number in it

2019-11-05 Thread Kevin Rushforth
On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph wrote: > In the HTMLEditor, when positioning the caret in a text and trying to set a > font-family that has a number in it is not working. > > Issue: In >

Re: RFR: 8233040: ComboBoxPopupControl: remove eventFilter for F4

2019-11-05 Thread Jeanette Winzenburg
On Mon, 4 Nov 2019 12:46:57 GMT, Ajit Ghaisas wrote: > On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg > wrote: > >> https://bugs.openjdk.java.net/browse/JDK-8233040 >> >> The issue is that the eventFilter in CBPC uses F4 for toggling the popup >> _and_ consumes it. This prevents

Re: [Rev 01] RFR: 8233040: ComboBoxPopupControl: remove eventFilter for F4

2019-11-05 Thread Jeanette Winzenburg
The pull request has been updated with additional changes. Added commits: - df3de536: changed as requested per review Changes: - all: https://git.openjdk.java.net/jfx/pull/28/files - new: https://git.openjdk.java.net/jfx/pull/28/files/2f015406..df3de536 Webrevs: - full:

Re: [Approved] RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-11-05 Thread Ambarish Rapte
On Tue, 29 Oct 2019 23:05:44 GMT, Kevin Rushforth wrote: > This PR updates the header files we use the build the OpenGL ES2 pipeline to > Mesa 19.2.1. See [this review > thread](https://mail.openjdk.java.net/pipermail/2d-dev/2019-October/010372.html) > for the equivalent change that is under

Re: RFR: WIP: 8230231: font-family not updated in HTMLEditor

2019-11-05 Thread Arun Joseph
On Thu, 10 Oct 2019 14:56:19 GMT, Hadzic Samir wrote: > On Thu, 10 Oct 2019 12:19:18 GMT, Kevin Rushforth wrote: > >> On Thu, 10 Oct 2019 09:12:57 GMT, Hadzic Samir wrote: >> >>> On Wed, 9 Oct 2019 20:09:58 GMT, Kevin Rushforth wrote: >>> On Wed, 9 Oct 2019 16:09:58 GMT, Hadzic Samir

Re: [Rev 01] RFR: 8232210: Update Mesa 3-D Headers to version 19.2.1

2019-11-05 Thread Kevin Rushforth
On Tue, 5 Nov 2019 06:28:33 GMT, Ambarish Rapte wrote: > On Wed, 30 Oct 2019 20:46:53 GMT, Kevin Rushforth wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 5686a382: Update third-party license file to remove unneeded