Re: [Rev 05] RFR: 8207957: TableSkinUtils should not contain actual code implementation

The pull request has been updated with additional changes. Added commits: - e1a9d2d0: Add more unit tests upon review Changes: - all: https://git.openjdk.java.net/jfx/pull/6/files - new: https://git.openjdk.java.net/jfx/pull/6/files/2b088993..e1a9d2d0 Webrevs: - full: htt

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

On Thu, 7 Nov 2019 12:07:55 GMT, Jeanette Winzenburg wrote: > On Fri, 1 Nov 2019 10:59:57 GMT, Hadzic Samir wrote: > >> On Tue, 29 Oct 2019 13:19:27 GMT, Hadzic Samir wrote: >> >>> On Wed, 9 Oct 2019 16:01:38 GMT, Kevin Rushforth wrote: >>> On Wed, 9 Oct 2019 12:26:31 GMT, Hadzic Sami

Re: [Integrated] RFR: 8233338: FX javadoc headings are out of sequence

Changeset: d46dcae7 Author:Kevin Rushforth Date: 2019-11-13 13:40:05 + URL: https://git.openjdk.java.net/jfx/commit/d46dcae7 828: FX javadoc headings are out of sequence Reviewed-by: aghaisas ! modules/javafx.base/src/main/java/javafx/beans/binding/package.html ! modules/

Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

Hmm, not getting any feedback so far, so wondering if there are currently any Java developers who take advantage of the ability of FXMLLoader to have FXML controllers implemented in any of the Java javax.script languages? For those, who use scripting languages for FXML controllers the request th

Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

Hi, have you considered directly contributing your proposed change via a PR on ? According to my experience this may speed up things considerably but don't forget to follow the procedures as outlined in .

Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

On 13.11.2019 15:40, Michael Paus wrote: > have you considered directly contributing your proposed change via a PR on > ? According to my experience this may speed > up things considerably but don't forget to follow the procedures as outlined > in >

Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

Actually, in this case, sending an email to this list is the right way to start this discussion. I had meant to reply last week, but was out of town (at Devoxx), and busy with other things. Before we take a look at a patch that implements what you propose to change, we need a little more infor

Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

On 13.11.2019 16:53, Kevin Rushforth wrote: > Actually, in this case, sending an email to this list is the right way to > start this discussion. I > had meant to reply last week, but was out of town (at Devoxx), and busy with > other things. > > Before we take a look at a patch that implements wh

Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

On 11/13/2019 9:42 AM, Rony G. Flatscher wrote: Will come up with a short reproducible testcase in ooRexx with brief comments such that the testcase could be understood without the runtime (ooRexx reads almost like pseudo-code). To reproduce the testcase one would need ooRexx and the Java bri

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Ghaisas wrote: > On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas wrote: > >> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >> >>> **Issue :** >>> https://bugs.openjdk.java.net/browse/JDK-8193445 >>> >>> **Background :** >>> The CSS performance im

Re: [Approved] RFR: 8231188: Update SQLite to version 3.30.1

On Wed, 6 Nov 2019 10:17:05 GMT, Arun Joseph wrote: > We currently use SQLite version 3.28.0. We should update to the latest stable > release version 3.30.1 released. > https://www.sqlite.org/index.html > > > > Commits: > - 24c6375d: 8231188: Update SQLite to version 3.30.1

Re: RFR: 8231188: Update SQLite to version 3.30.1

On Wed, 6 Nov 2019 10:17:05 GMT, Arun Joseph wrote: > We currently use SQLite version 3.28.0. We should update to the latest stable > release version 3.30.1 released. > https://www.sqlite.org/index.html > > > > Commits: > - 24c6375d: 8231188: Update SQLite to version 3.30.1

Re: RFR: 8087980: Add property to disable Monocle cursor

On Tue, 29 Oct 2019 11:31:18 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 10:10:32 GMT, Dell Green > wrote: > >> On Tue, 29 Oct 2019 09:53:28 GMT, Johan Vos wrote: >> >>> On Tue, 8 Oct 2019 12:03:46 GMT, Kevin Rushforth wrote: >>> On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green

Re: RFR: 8231372: Correctly terminate secondary event loop in JFXPanel.setScene()

On Mon, 21 Oct 2019 22:52:47 GMT, Kevin Rushforth wrote: > On Thu, 17 Oct 2019 15:28:31 GMT, Kevin Rushforth wrote: > >> On Thu, 17 Oct 2019 15:28:30 GMT, mruzicka >> wrote: >> >>> On Thu, 17 Oct 2019 15:28:28 GMT, mruzicka >>> wrote: >>> Secondary event loop introduced as a means of

Re: RFR: 8087980: Add property to disable Monocle cursor

On Wed, 13 Nov 2019 19:57:04 GMT, Kevin Rushforth wrote: > On Tue, 29 Oct 2019 11:31:18 GMT, Kevin Rushforth wrote: > >> On Tue, 29 Oct 2019 10:10:32 GMT, Dell Green >> wrote: >> >>> On Tue, 29 Oct 2019 09:53:28 GMT, Johan Vos wrote: >>> On Tue, 8 Oct 2019 12:03:46 GMT, Kevin Rushfort

Re: RFR: 8087980: Add property to disable Monocle cursor

+1 Am 13.11.19 um 21:50 schrieb Dell Green: On Wed, 13 Nov 2019 19:57:04 GMT, Kevin Rushforth wrote: On Tue, 29 Oct 2019 11:31:18 GMT, Kevin Rushforth wrote: On Tue, 29 Oct 2019 10:10:32 GMT, Dell Green wrote: On Tue, 29 Oct 2019 09:53:28 GMT, Johan Vos wrote: On Tue, 8 Oct 2019 12:

Re: RFR: 8087980: Add property to disable Monocle cursor

On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green <12861109+dellgr...@users.noreply.github.com> wrote: > Often on embedded systems a cursor is not a valid input modality. On some of > these systems, when the javafx toolkit initialises the native hardware > cursor, it produces artefacts which can be s

Re: [Rev 02] RFR: 8200224: Multiple press event when JFXPanel gains focus

On Tue, 12 Nov 2019 10:23:16 GMT, Florian Kirmaier wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 5cd96a56: JDK-8200224 > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/25/files > - new: https://git.openjdk.java.

Re: RFR: 8087980: Add property to disable Monocle cursor

On Wed, 13 Nov 2019 21:34:06 GMT, John Neffenger wrote: > On Tue, 8 Oct 2019 12:03:42 GMT, Dell Green > <12861109+dellgr...@users.noreply.github.com> wrote: > >> Often on embedded systems a cursor is not a valid input modality. On some of >> these systems, when the javafx toolkit initialises

Re: RFR: 8200224: Multiple press event when JFXPanel gains focus

On Wed, 13 Nov 2019 01:17:44 GMT, Kevin Rushforth wrote: > On Tue, 12 Nov 2019 10:35:36 GMT, Florian Kirmaier > wrote: > >> On Wed, 6 Nov 2019 08:30:47 GMT, Kevin Rushforth wrote: >> >>> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier >>> wrote: >>> Original PR: https://github.com

RFR: 8234110: SwingFXUtilsTest is unsuitable for unit test framework

This fixes [JDK-8234110](https://bugs.openjdk.java.net/browse/JDK-8234110) by moving `SwingFXUtilsTest` from the `:swing` project to the `:systemTests` project. As explained in the JBS issue, `SwingFXUtilsTest` must be run in its own VM, since it starts and stops the FX runtime, so must be in th

Re: RFR: 8234110: SwingFXUtilsTest is unsuitable for unit test framework

On Wed, 13 Nov 2019 22:54:01 GMT, Kevin Rushforth wrote: > This fixes [JDK-8234110](https://bugs.openjdk.java.net/browse/JDK-8234110) by > moving `SwingFXUtilsTest` from the `:swing` project to the `:systemTests` > project. As explained in the JBS issue, `SwingFXUtilsTest` must be run in its >

Re: [Approved] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

On Wed, 6 Nov 2019 14:28:20 GMT, Nir Lisker wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - a1cdb37b: Removed whitespaces in @Deprecated comments > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/30/files > - new: h

Re: RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

On Wed, 6 Nov 2019 12:54:40 GMT, Kevin Rushforth wrote: > On Wed, 6 Nov 2019 11:50:27 GMT, Nir Lisker wrote: > >> On Wed, 6 Nov 2019 07:12:26 GMT, Robin Westberg >> wrote: >> >>> On Wed, 6 Nov 2019 05:07:56 GMT, Kevin Rushforth wrote: >>> On Wed, 6 Nov 2019 05:04:28 GMT, Kevin Rushfor