RFR: 8210955: DOMTest::testEventListenerCascade fails

2019-11-18 Thread Arun Joseph
Modified the test to work with WebView's ordering of capturing and bubbling event listeners. Commits: - cbef0069: DOMTest::testEventListenerCascade fails Changes: https://git.openjdk.java.net/jfx/pull/46/files Webrev: https://webrevs.openjdk.java.net/jfx/46/webrev.00 Issue:

Re: [Integrated] RFR: 8233420: Upgrade to gcc 8.3 on Linux

2019-11-18 Thread Kevin Rushforth
Changeset: aad17206 Author:Kevin Rushforth Date: 2019-11-18 18:40:00 + URL: https://git.openjdk.java.net/jfx/commit/aad17206 8233420: Upgrade to gcc 8.3 on Linux Reviewed-by: arapte, jvos ! build.properties

Re: [Rev 01] RFR: 8233420: Upgrade to gcc 8.3 on Linux

2019-11-18 Thread Kevin Rushforth
The pull request has been updated with a complete new set of changes (possibly due to a rebase). Commits: - f538e26b: Merge branch 'master' into 8233420-gcc-8.3 - ab06dc58: 8233420: Upgrade to gcc 8.3 on Linux Changes: https://git.openjdk.java.net/jfx/pull/41/files Webrev: h

Re: [Integrated] RFR: 8232063: Upgrade gradle to version 6.0

2019-11-18 Thread Kevin Rushforth
Changeset: 42040c4c Author:Kevin Rushforth Date: 2019-11-18 18:22:51 + URL: https://git.openjdk.java.net/jfx/commit/42040c4c 8232063: Upgrade gradle to version 6.0 Reviewed-by: arapte, jvos ! build.gradle ! build.properties ! buildSrc/build.gradle ! gradle/legal/gradle.md ! g

Re: [Integrated] RFR: 8234239: [TEST_BUG] Reenable few ignored web tests

2019-11-18 Thread Kevin Rushforth
Changeset: aab07a4d Author:Arun Joseph Committer: Kevin Rushforth Date: 2019-11-18 18:17:39 + URL: https://git.openjdk.java.net/jfx/commit/aab07a4d 8234239: [TEST_BUG] Reenable few ignored web tests Reviewed-by: kcr ! modules/javafx.web/src/test/java/test/com/sun/webkit/net

Re: RFR: 8233420: Upgrade to gcc 8.3 on Linux

2019-11-18 Thread Kevin Rushforth
On Thu, 14 Nov 2019 23:34:50 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 23:34:49 GMT, Kevin Rushforth wrote: > >> [JDK-8233420](https://bugs.openjdk.java.net/browse/JDK-8233420) >> >> This bumps the Linux compiler version to gcc 8.3 to match JDK 14. I have run >> a full build and test,

Re: [Integrated] RFR: 8233421: Upgrade to Visual Studio 2017 version 15.9.16

2019-11-18 Thread Kevin Rushforth
Changeset: 95ad6017 Author:Kevin Rushforth Date: 2019-11-18 18:17:14 + URL: https://git.openjdk.java.net/jfx/commit/95ad6017 8233421: Upgrade to Visual Studio 2017 version 15.9.16 Reviewed-by: prr, arapte, jvos ! build.properties

Re: RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-18 Thread Kevin Rushforth
On Wed, 13 Nov 2019 23:47:58 GMT, Kevin Rushforth wrote: > On Wed, 6 Nov 2019 12:54:40 GMT, Kevin Rushforth wrote: > >> On Wed, 6 Nov 2019 11:50:27 GMT, Nir Lisker wrote: >> >>> On Wed, 6 Nov 2019 07:12:26 GMT, Robin Westberg >>> wrote: >>> On Wed, 6 Nov 2019 05:07:56 GMT, Kevin Rushf

Re: [Approved] RFR: 8233420: Upgrade to gcc 8.3 on Linux

2019-11-18 Thread Johan Vos
On Thu, 14 Nov 2019 23:34:49 GMT, Kevin Rushforth wrote: > [JDK-8233420](https://bugs.openjdk.java.net/browse/JDK-8233420) > > This bumps the Linux compiler version to gcc 8.3 to match JDK 14. I have run > a full build and test, including WebKit and media. > > > > Commits: >

Re: [Approved] RFR: 8233421: Upgrade to Visual Studio 2017 version 15.9.16

2019-11-18 Thread Johan Vos
On Thu, 14 Nov 2019 23:31:34 GMT, Kevin Rushforth wrote: > [JDK-8233421](https://bugs.openjdk.java.net/browse/JDK-8233421) > > This bumps the windows compiler version to VS2017 version 15.9.16 to match > JDK 14. I have run a full build and test, including WebKit and media. > >

Re: [Approved] RFR: 8232063: Upgrade gradle to version 6.0

2019-11-18 Thread Johan Vos
On Mon, 11 Nov 2019 15:22:48 GMT, Kevin Rushforth wrote: > This PR upgrades the version of gradle used to build JavaFX to 6.0. In > addition to keeping up to date, this will allow us to subsequently upgrade > the boot JDK to JDK 13. > > This change does the following: > > 1. Use ivy `patternL

Re: RFR: 8217472: Add attenuation for PointLight

2019-11-18 Thread Nir Lisker
On Mon, 18 Nov 2019 18:00:45 GMT, Nir Lisker wrote: > CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 > > > > Commits: > - a388fb92: Fixed whitespaces > - 415927e6: Correction for indexes > - 3450ffe9: Docs and year update > - 4b63a01f: Merge remote-tracking branch >

RFR: 8217472: Add attenuation for PointLight

2019-11-18 Thread Nir Lisker
CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 Commits: - a388fb92: Fixed whitespaces - 415927e6: Correction for indexes - 3450ffe9: Docs and year update - 4b63a01f: Merge remote-tracking branch 'nlisker/8217472_Add_attenuation_for_PointLight' into 8217472_Add_attenu

Re: [Rev 01] RFR: 8234239: [TEST_BUG] Reenable few ignored web tests

2019-11-18 Thread Kevin Rushforth
On Fri, 15 Nov 2019 23:03:46 GMT, Kevin Rushforth wrote: > On Fri, 15 Nov 2019 10:01:51 GMT, Arun Joseph wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - ca460353: Remove ignore imports and update copyright >> >> Changes

Re: [Approved] RFR: 8234239: [TEST_BUG] Reenable few ignored web tests

2019-11-18 Thread Kevin Rushforth
On Sun, 17 Nov 2019 12:08:44 GMT, Arun Joseph wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 8c2b988d: Modified LeakTest.testOleg > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/42/files > - new: https://git.open

Re: [Approved] RFR: 8233421: Upgrade to Visual Studio 2017 version 15.9.16

2019-11-18 Thread Ambarish Rapte
On Thu, 14 Nov 2019 23:31:34 GMT, Kevin Rushforth wrote: > [JDK-8233421](https://bugs.openjdk.java.net/browse/JDK-8233421) > > This bumps the windows compiler version to VS2017 version 15.9.16 to match > JDK 14. I have run a full build and test, including WebKit and media. > >

Re: [Rev 01] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-18 Thread Ambarish Rapte
On Wed, 6 Nov 2019 14:28:20 GMT, Nir Lisker wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - a1cdb37b: Removed whitespaces in @Deprecated comments > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/30/files > - new: h

Re: [Approved] RFR: 8233420: Upgrade to gcc 8.3 on Linux

2019-11-18 Thread Ambarish Rapte
On Thu, 14 Nov 2019 23:34:49 GMT, Kevin Rushforth wrote: > [JDK-8233420](https://bugs.openjdk.java.net/browse/JDK-8233420) > > This bumps the Linux compiler version to gcc 8.3 to match JDK 14. I have run > a full build and test, including WebKit and media. > > > > Commits: >

Re: [Integrated] RFR: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests

2019-11-18 Thread Ambarish Rapte
Changeset: 3e0557a8 Author:Ambarish Rapte Date: 2019-11-18 16:04:06 + URL: https://git.openjdk.java.net/jfx/commit/3e0557a8 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests Reviewed-by: kcr ! modules/javafx.graphics/src/test/java/test/com/sun/javafx/sg/prism/Ren

Re: RFR: 8087980: Add property to disable Monocle cursor

2019-11-18 Thread Dell Green
On Sun, 17 Nov 2019 10:04:36 GMT, Dell Green wrote: > On Sat, 16 Nov 2019 17:51:56 GMT, John Neffenger > wrote: > >> On Sat, 16 Nov 2019 06:09:35 GMT, Dell Green >> wrote: >> >>> On Sat, 16 Nov 2019 00:32:31 GMT, John Neffenger >>> wrote: >>> On Wed, 13 Nov 2019 22:04:36 GMT, Dell

Re: [Rev 01] RFR: 8087980: Add property to disable Monocle cursor

2019-11-18 Thread Dell Green
The pull request has been updated with additional changes. Added commits: - 1f6e282d: changed from system propert debug logging to javafx platform logger Changes: - all: https://git.openjdk.java.net/jfx/pull/5/files - new: https://git.openjdk.java.net/jfx/pull/5/files/cfbbc

RFR: 8234056: Upgrade to libxslt 1.1.34

2019-11-18 Thread Arun Joseph
We need to update the version of libxslt to the latest version, 1.1.34. Commits: - 2d9c0bf3: 8234056: Upgrade to libxslt 1.1.34 Changes: https://git.openjdk.java.net/jfx/pull/45/files Webrev: https://webrevs.openjdk.java.net/jfx/45/webrev.00 Issue: https://bugs.openjdk.java.

Re: [Approved] RFR: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests

2019-11-18 Thread Kevin Rushforth
On Sun, 17 Nov 2019 16:41:27 GMT, Ambarish Rapte wrote: > This is a simple fix to correct all the ignored tag in graphics unit tests. > > Corrections are: > 1. Each ignored test must be associated with a bug. There are new bugs > reported for all the tests which are missing a bug. > 2. Replace

Re: [Approved] RFR: 8232063: Upgrade gradle to version 6.0

2019-11-18 Thread Ambarish Rapte
On Mon, 11 Nov 2019 15:22:48 GMT, Kevin Rushforth wrote: > This PR upgrades the version of gradle used to build JavaFX to 6.0. In > addition to keeping up to date, this will allow us to subsequently upgrade > the boot JDK to JDK 13. > > This change does the following: > > 1. Use ivy `patternL