It would have to allow anyone who has reviewer status to add that comment.
Not just the author since if they knew we would have less need for it.
-Phil.
> On Dec 18, 2019, at 11:31 AM, Kevin Rushforth
> wrote:
>
> That's an interesting idea. It would, of course, need to disallow reducing
> th
That's an interesting idea. It would, of course, need to disallow
reducing the number below the minimum specified in .jcheck/conf (e.g.,
we wouldn't allow "/reviewers 0").
-- Kevin
On 12/18/2019 10:36 AM, Nir Lisker wrote:
The client libraries in the OpenJDK do as a default rule,
ex
>
> The client libraries in the OpenJDK do as a default rule, excusing simple
> fixes.
>
Then maybe it would be helpful to have a "/reviewers n" command that will
tell the bot how many reviewers are needed. It's less convoluted than the
CSR tracking and basically replaces the comment a reviewer wo
On Wed, 18 Dec 2019 18:29:59 GMT, Hadzic Samir wrote:
>> @Maxoudela the CSR has been approved. Go ahead and `/integrate` this and I
>> will sponsor it.
>
> `/integrate`
I think you need to enter the integrate command "as-is" without the
back-quotes. the `/` needs to be the first character.
-
On Wed, 18 Dec 2019 17:32:05 GMT, Kevin Rushforth wrote:
>> Looks good.
>>
>> Once the CSR is approved, this can be integrated.
>
> @Maxoudela the CSR has been approved. Go ahead and `/integrate` this and I
> will sponsor it.
`/integrate`
-
PR: https://git.openjdk.java.net/jfx/p
On Mon, 16 Dec 2019 21:32:58 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> Looks good.
>
> Once the CSR is approved, this can be integrated.
@Maxoudela the CSR has been approved. Go ahead and `/integrate` this and I will
sponsor it.
--
On Tue, 17 Dec 2019 21:43:19 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix looks good (with a minor formatting comment). The test needs a couple
> of changes.
@arapte - can you be the second reviewer on this?
-
PR: https://
Changeset: 4e005e4e
Author:Ambarish Rapte
Date: 2019-12-18 17:05:51 +
URL: https://git.openjdk.java.net/jfx/commit/4e005e4e
8227808: Make GTK3 libraries mandatory for building on Linux
Reviewed-by: jvos, kcr
! buildSrc/linux.gradle
Changeset: 1140d343
Author:Ambarish Rapte
Date: 2019-12-18 17:03:12 +
URL: https://git.openjdk.java.net/jfx/commit/1140d343
8196587: Remove use of deprecated finalize method from JPEGImageLoader
Reviewed-by: kcr, jvos
! modules/javafx.graphics/src/main/java/com/sun/javafx/iio
On Tue, 17 Dec 2019 14:29:22 GMT, Johan Vos wrote:
>> The finalize() method is deprecated in JDK9. See [Java 9 deprecated
>> features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html).
>> And so the
>> [PiscesRenderer.finalize()](https://github.com/openjdk/jfx/
Sent a message to openfx-discuss last month but got not response. That
list doesn't seem very popular so I figured I'd forward to this list.
Any thoughts on draggable tabs supporting docking behaviors?
-- Forwarded message -
From: Christian Carlow
Date: Sun, Nov 24, 2019 at 9:50
So is there some “review complete” or “review closed” or some following state
available for the bot to key on maybe instead of reacting to one reviewer
completion?
Eric Bresie
ebre...@gmail.com
> On December 16, 2019 at 9:38:00 AM CST, Kevin Rushforth
> wrote:
> That's a good question about wh
On Wed, 18 Dec 2019 12:52:12 GMT, Dell Green
wrote:
>> Often on embedded systems a cursor is not a valid input modality. On some of
>> these systems, when the javafx toolkit initialises the native hardware
>> cursor, it produces artefacts which can be seen on screen (in the
>> framebuffer for
Well, Windows glass native implementation just ignores it.
I am working on some changes on linux glass implementation because the current
implementation has too many special case handling (I have added some myself to
fix some bugs). I want to do a more "direct flow" code. Will file a bug and
pr
14 matches
Mail list logo