[RFR] 8233942: Update to 609.1 version of WebKit

2020-01-20 Thread Guru
Hi Kevin, Johan, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8233942 PR : https://github.com/openjdk/jfx/pull/91 Fix has latest GTK Webkit 2.26 (609.1) merged into jfx.

Re: RFR: 8236839: System menubar removed when other menubars are created or modified

2020-01-20 Thread Kevin Rushforth
On Tue, 14 Jan 2020 20:06:58 GMT, Johan Kaving wrote: >> This pull request fixes the sceneProperty listener in `MenuBarSkin` so that >> we leave the >> current system menubar alone when other menubars are changed. >> >> It also adds a test case that reproduces the problem before the fix. > >

Re: RFR: 8236839: System menubar removed when other menubars are created or modified

2020-01-20 Thread Johan Kaving
On Tue, 14 Jan 2020 19:50:28 GMT, Johan Kaving wrote: > This pull request fixes the sceneProperty listener in `MenuBarSkin` so that > we leave the > current system menubar alone when other menubars are changed. > > It also adds a test case that reproduces the problem before the fix. I just

RFR: 8236839: System menubar removed when other menubars are created or modified

2020-01-20 Thread Johan Kaving
This pull request fixes the sceneProperty listener in `MenuBarSkin` so that we leave the current system menubar alone when other menubars are changed. It also adds a test case that reproduces the problem before the fix. - Commits: - 7910ab27: Don't always remove system menubar

Re: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-20 Thread Frederic Thevenet
On Mon, 20 Jan 2020 05:06:50 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 2 additional commits. > > Looks good to me. > Below is just an observation about time taken by the API, > Platform: Windows10, `maxTextureSize`: 4096 > For a snapshot of (4096 * n, 4096 * n): each

RFR: 8237078: Media build code broken on XCode 11

2020-01-20 Thread Johan Vos
Fix JDK-8237078 replace the objc_msgSend call with a direct objC call. The fix works on XCode 10.1 and XCode 11.3 Tested using java -Djfxmedia.platforms=OSXPlatform with MediaPlayer playing an mp3. - Commits: - 33582c1d: Fix 8237078 : media build code broken on XCode 11 Changes:

RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-20 Thread Robert Lichtenberger
Test simulates a single mouse-released event. Fix simply guards against the null case. - Commits: - 923a63b2: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: https://git.openjdk.java.net/jfx/pull/89/files Webrev: https://webrevs.openjdk.java.net/jfx/89/webrev.00