Canvas -> globalAlpha for custom / round clips

2020-01-26 Thread it
Hello everybody Maybe I'm making a mistake, but it seems to me that graphicContext.restore() for globalAlpha doesn't work if clipping is used that was not constructed via rect(...). Java: openjdk 11.0.6 2020-01-14 JavaFX: 13 OS: Windows 10 Pro Code: package foo.bar; import

Re: [Rev 01] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-26 Thread Robert Lichtenberger
On Fri, 24 Jan 2020 15:41:20 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java > line 1994: > >> 1993: private ListChangeListener childListener = new >>

Re: [Rev 02] RFR: 8237372: NullPointerException in TabPaneSkin.stopDrag

2020-01-26 Thread Robert Lichtenberger
> Test simulates a single mouse-released event. > Fix simply guards against the null case. The pull request has been updated with 1 additional commit. - Added commits: - a54a5306: 8237372: NullPointerException in TabPaneSkin.stopDrag Changes: - all:

Re: TableView slow vertical scrolling with 300+ columns

2020-01-26 Thread Jonathan Giles
It's been a wee while since I built TableView, but from memory there is code in there that virtualises the columns, such that those that are scrolled out of view are not being included in the scenegraph needlessly. >From memory, to achieve this all you needed to do was set a fixed row height on

Re: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-26 Thread Frederic Thevenet
On Sun, 26 Jan 2020 11:40:06 GMT, Frederic Thevenet wrote: >>> the `WriteableImage` used to collate the tiles and the tiles returned from >>> the `RTTexture` have different pixel formats (`IntARGB` for the tile and >>> `byteBGRA` for the `WriteableImage`). >> >> Where did you see these? >>

Re: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-26 Thread Frederic Thevenet
On Sat, 25 Jan 2020 20:24:54 GMT, Nir Lisker wrote: >>> profiling a run of the benchmark shows that a lot of time is spent into >>> `IntTo4ByteSameConverter::doConvert` >> >> This is a bit naive, but what if you parallelize the code there? I didn't >> test that this produces the correct