Re: [EXTERNAL] Explanation of different scaling factors anywhere?

2020-01-27 Thread Tom Eugelink
ResponsivePane is an attempt to do something in that way, but I chose a slightly different approach where the system automatically switches between different layouts and CSS files depending on the window's size. It has a common area (reusable nodes) and then specific layouts per size. https://t

RE: [EXTERNAL] Explanation of different scaling factors anywhere?

2020-01-27 Thread Pedro Duque Vieira
Hi, AFAIK, -fx-padding values are also affected as long as they're also defined in em. I agree, would also be nice for other things to scale automatically, depending on the font size defined in root. I don't think other properties besides -fx-padding also scale. One thing that would be nice to h

Re: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-27 Thread Frederic Thevenet
On Mon, 27 Jan 2020 15:30:27 GMT, Kevin Rushforth wrote: >> I would be very cautious of using multi-threading here. In any case, I think >> that the issues around absolute performance could be handled separately. >> >> Having said that, given my review comments, along with the concerns over >>

RE: [EXTERNAL] Explanation of different scaling factors anywhere?

2020-01-27 Thread David Grieve
Wouldn't this just be a scale transform? > -Original Message- > From: openjfx-dev On Behalf Of > Mike Hearn > Sent: Monday, January 27, 2020 11:00 AM > To: openjfx-dev@openjdk.java.net > Subject: [EXTERNAL] Explanation of different scaling factors anywhere? > > Hello, > > A feature I o

Explanation of different scaling factors anywhere?

2020-01-27 Thread Mike Hearn
Hello, A feature I often miss when using non-web GUIs is support for browser style zooming. In JavaFX it is quite easy to specify all font sizes in terms of "ems", relative sizes ("largest") or percentages and then adjust the base font size on a root node inside key handlers. This works OK but doe

Re: [Rev 01] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-01-27 Thread Florian Kirmaier
On Mon, 6 Jan 2020 23:05:13 GMT, Kevin Rushforth wrote: >> I agree. Static analysis tools are quite limited in this regard, and are in >> now way a substitute for regression testing. >> >> So the question is how best to test fixes for memory leaks at runtime. Our >> current approach can be bes

Re: [Rev 02] RFR: 8236259: MemoryLeak in ProgressIndicator

2020-01-27 Thread Florian Kirmaier
> Hi everyone, > > ticket: https://bugs.openjdk.java.net/browse/JDK-8236259 > > The fix itself is quite straight forward. > It basically just removed the listener which causes the leak. > > The unit-test for the fix is a bit more complicated. > > I added a library JMemoryBuddy https://github.co

Re: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-27 Thread Kevin Rushforth
On Mon, 27 Jan 2020 13:47:43 GMT, Kevin Rushforth wrote: >>> >>> >>> > profiling a run of the benchmark shows that a lot of time is spent into >>> > `IntTo4ByteSameConverter::doConvert` >>> >>> This is a bit naive, but what if you parallelize the code there? I didn't >>> test that this produ

Re: TableView slow vertical scrolling with 300+ columns

2020-01-27 Thread Clemens Kadura
Hello Ed, hello all, It is also the first time that I become active in this mailing list, although I'm already monitoring this list for half a year to get familiar with your conventions. I am co-founder of a software and consulting company in Germany. We develop a system (JACAMAR) that combine

Re: TableView slow vertical scrolling with 300+ columns

2020-01-27 Thread Ed Kennard
Hi Jonathan, Thanks for jumping into the discussion. I’ve tested setting a value for fixedCellSize… Against Java 8, there is indeed a _major_ improvement in vertical scrolling performance, but there are some issues that come with that. Performance of horizontal scrolling suffers, becoming sim

Re: [Rev 03] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-27 Thread Kevin Rushforth
On Sun, 26 Jan 2020 11:58:27 GMT, Frederic Thevenet wrote: >>> >>> >>> > the `WriteableImage` used to collate the tiles and the tiles returned >>> > from the `RTTexture` have different pixel formats (`IntARGB` for the tile >>> > and `byteBGRA` for the `WriteableImage`). >>> >>> Where did yo

Re: [Integrated] RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

2020-01-27 Thread Kevin Rushforth
Changeset: aa6f3a4e Author:Robert Lichtenberger Committer: Kevin Rushforth Date: 2020-01-27 13:43:47 + URL: https://git.openjdk.java.net/jfx/commit/aa6f3a4e 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 Reviewed-by: ghb, kcr ! modules/javaf

Re: Proposed schedule for JavaFX 14

2020-01-27 Thread Kevin Rushforth
As a reminder, the RDP2 date for JavaFX 14 is Monday, February 3, at 23:59 Pacific time. This is the deadline for all P3-P4 bugs for JavaFX 14. Please allow sufficient time for your review to complete ahead of that deadline. During RDP2 P1-P2 bugs can be fixed for JavaFX 14 with approval, as w