On Wed, 29 Jan 2020 20:47:11 GMT, Kevin Rushforth wrote:
>> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do
>> not play backwards after being paused) has been split to deal with
>> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not
>> embedded](htt
On Tue, 28 Jan 2020 19:19:57 GMT, Nir Lisker wrote:
> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do
> not play backwards after being paused) has been split to deal with
> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not
> embedded](https://bugs
> This proposed change does the following:
>
> - Ports DND target to use GTK reducing code size and adding extra text /
> image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward co
On Wed, 29 Jan 2020 19:10:22 GMT, Frederic Thevenet
wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown
>> from snapshot if dimensions are larger than max texture size
>>
>> In order to do that, it simply captures snapshots in multiple tiles of
>> maxTextureSiz
> This proposed change does the following:
>
> - Ports DND target to use GTK reducing code size and adding extra text /
> image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward co
On Wed, 29 Jan 2020 16:33:16 GMT, Nir Lisker wrote:
>> The code changes look good to me. As long as you are willing to address the
>> follow-on issues for openjfx15, I'll approve this PR for openjfx14, once I
>> run my last test.
>>
>> I did a fair bit of testing of the functionality, which re
Changeset: b96bc52b
Author:Guru Hb
Date: 2020-01-29 16:44:56 +
URL: https://git.openjdk.java.net/jfx/commit/b96bc52b
8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in
DumpRenderTree
Reviewed-by: kcr
! modules/javafx.web/src/main/java/com/sun/javafx/webkit/
On Wed, 29 Jan 2020 16:32:31 GMT, Kevin Rushforth wrote:
>> AnimationBase and WebAnimation are two different abstract animation API
>> provider. By default KeyFrameAnimation (which is a sub class of
>> AnimationBase) is used for controlling and rendering the CSS animation.
>> Enabling "WebAnim
On Wed, 29 Jan 2020 15:42:51 GMT, Kevin Rushforth wrote:
>> I need to re-review the updated PR.
>
> The code changes look good to me. As long as you are willing to address the
> follow-on issues for openjfx15, I'll approve this PR for openjfx14, once I
> run my last test.
>
> I did a fair bit
On Wed, 29 Jan 2020 11:29:10 GMT, Guru Hb wrote:
> AnimationBase and WebAnimation are two different abstract animation API
> provider. By default KeyFrameAnimation (which is a sub class of
> AnimationBase) is used for controlling and rendering the CSS animation.
> Enabling "WebAnimationsCSSInt
On Wed, 29 Jan 2020 13:59:12 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> I need to re-review the updated PR.
The code changes look good to me. As long as you are willing to address the
follow-on issues for openjfx15, I'll approve this PR for op
On Wed, 29 Jan 2020 12:57:41 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> Marked as reviewed by kcr (Lead).
> the -m32 option seems to be ignored by the compiler:
> cl : Command line warning D9002 : ignoring unknown option '-m32'
>
> However, I
On Wed, 29 Jan 2020 13:59:32 GMT, Frederic Thevenet
wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown
>> from snapshot if dimensions are larger than max texture size
>>
>> In order to do that, it simply captures snapshots in multiple tiles of
>> maxTextureSiz
Changeset: 5a0e71b8
Author:Robert Lichtenberger
Committer: Ambarish Rapte
Date: 2020-01-29 06:25:21 +
URL: https://git.openjdk.java.net/jfx/commit/5a0e71b8
8237372: NullPointerException in TabPaneSkin.stopDrag
Reviewed-by: arapte
!
modules/javafx.controls/src/main/java/java
Changeset: 79fc0d0d
Author:Ambarish Rapte
Date: 2020-01-28 12:35:52 +
URL: https://git.openjdk.java.net/jfx/commit/79fc0d0d
8232824: Removing TabPane with strong referenced content causes memory leak
from weak one
Reviewed-by: kcr, aghaisas
! modules/javafx.graphics/src/main
Changeset: aa6f3a4e
Author:Robert Lichtenberger
Committer: Kevin Rushforth
Date: 2020-01-27 13:43:47 +
URL: https://git.openjdk.java.net/jfx/commit/aa6f3a4e
8236912: NullPointerException when clicking in WebView with Button 4 or Button 5
Reviewed-by: ghb, kcr
! modules/javaf
On Wed, 29 Jan 2020 12:58:00 GMT, Guru Hb wrote:
>> cl : Command line warning D9002 : ignoring unknown option '-m32'
>>
>> post fix for "https://trac.webkit.org/changeset/242724/webkit"; makes use of
>> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux.
>> '-m32' flag is
Hi Rony,
The RFE you filed is now available here:
https://bugs.openjdk.java.net/browse/JDK-8238080
-- Kevin
On 1/25/2020 6:32 AM, Rony G. Flatscher wrote:
Hi Kevin,
On 24.01.2020 16:50, Kevin Rushforth wrote:
This bug was transferred to the JDK project on 28-Nov-2019. I don't know why
you
On Tue, 28 Jan 2020 16:59:27 GMT, Thiago Milczarek Sayao
wrote:
>> Sizing and positioning completed and fairly tested.
>>
>> Will look into mouse grabbing.
>
> To anyone willing to test this, here is a binary test-release for linux:
>
> https://github.com/tsayao/jfx/releases/tag/test-glass-gt
> This proposed change does the following:
>
> - Ports DND target to use GTK reducing code size and adding extra text /
> image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward co
AnimationBase and WebAnimation are two different abstract animation API
provider. By default KeyFrameAnimation (which is a sub class of AnimationBase)
is used for controlling and rendering the CSS animation.
Enabling "WebAnimationsCSSIntegrationEnabled" overrides the
CSSAnimationController to u
> cl : Command line warning D9002 : ignoring unknown option '-m32'
>
> post fix for "https://trac.webkit.org/changeset/242724/webkit"; makes use of
> cross compiling 32 bit JSC in a 64 bit and its holds good only for Linux.
> '-m32' flag is gcc specifc and on windows cl.exe (visual studio) doesn
On Tue, 28 Jan 2020 23:42:08 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm line 2300:
>
>> 2299:
>> 2300: if (architecture() eq "x86_64" && shouldBuild32Bit() && (isJava()
>> &&
23 matches
Mail list logo
