Re: RFR: 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)

2020-01-30 Thread Phil Race
On Thu, 30 Jan 2020 23:07:53 GMT, Kevin Rushforth wrote: > This is a fix for > [JDK-8231513](https://bugs.openjdk.java.net/browse/JDK-8231513) to disable > the use of `CGEventTap` when running on macOS 10.15 or later. > > The effect of this bug is that a scary dialog is shown for all users the

Re: RFR: 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)

2020-01-30 Thread Kevin Rushforth
On Thu, 30 Jan 2020 23:07:53 GMT, Kevin Rushforth wrote: > This is a fix for > [JDK-8231513](https://bugs.openjdk.java.net/browse/JDK-8231513) to disable > the use of `CGEventTap` when running on macOS 10.15 or later. > > The effect of this bug is that a scary dialog is shown for all users the

RFR: 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)

2020-01-30 Thread Kevin Rushforth
This is a fix for [JDK-8231513](https://bugs.openjdk.java.net/browse/JDK-8231513) to disable the use of `CGEventTap` when running on macOS 10.15 or later. The effect of this bug is that a scary dialog is shown for all users the first time they run a JavaFX application and move the mouse is move

Re: RFR: 8237975: Non-embedded Animations do not play backwards after being paused

2020-01-30 Thread Kevin Rushforth
On Tue, 28 Jan 2020 19:19:57 GMT, Nir Lisker wrote: > [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do > not play backwards after being paused) has been split to deal with > [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not > embedded](https://bugs

Re: RFR: 8237770: Error creating fragment phong shader on iOS

2020-01-30 Thread Kevin Rushforth
On Fri, 24 Jan 2020 11:31:02 GMT, Jose Pereda wrote: > This PR defines a pre-processor in the phong frag files to avoid inline > declaration of #extension when several frags are combined that leads to the > error: > > syntax error: #extension must always be before any non-preprocessor tokens

Re: [Rev 01] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

2020-01-30 Thread Kevin Rushforth
On Wed, 29 Jan 2020 15:36:52 GMT, Guru Hb wrote: >> Marked as reviewed by kcr (Lead). > >> the -m32 option seems to be ignored by the compiler: >> cl : Command line warning D9002 : ignoring unknown option '-m32' >> >> However, I agree it is better to conditionally remove it. > "-m32" required f

Re: RFR: 8237782: Only read advances up to the minimum of the numHorMetrics or the available font data.

2020-01-30 Thread Kevin Rushforth
On Fri, 24 Jan 2020 17:08:42 GMT, Phil Race wrote: > … the available font data. Looks like GitHub truncated your title, so I fixed it to match the JBS title. - PR: https://git.openjdk.java.net/jfx/pull/95

RFR: 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)

2020-01-30 Thread Kevin Rushforth
The Skara bot isn't sending email at the moment, so here is an RFR for jfx14: PR: https://github.com/openjdk/jfx/pull/102 JBS: https://bugs.openjdk.java.net/browse/JDK-8231513 This is a fix for [JDK-8231513](https://bugs.openjdk.java.net/browse/JDK-8231513) to disable the use of `CGEventTap`

Re: [EXTERNAL] Explanation of different scaling factors anywhere?

2020-01-30 Thread Mike Hearn
I'm afraid I disagree. My eyesight isn't great and I like to zoom web apps to sizes that most designers would consider wrong/bad/absurd, at least when possible. How far I can go depends a lot on the app. Many modern desktop apps feel far too dense and with fonts that are uncomfortably small for me.

Re: Scary keystroke logging dialog on macOS 10.15 Catalina (JDK-8231513)

2020-01-30 Thread Kevin Rushforth
My obvious attempt failed to get any touch events delivered to the app. There is also code in GestureRecognizers (internal to glass) to register listeners for touch events that will then in some cases be turned into gestures, but it's disabled by default. So it really does look like we are gen

Re: Scary keystroke logging dialog on macOS 10.15 Catalina (JDK-8231513)

2020-01-30 Thread Kevin Rushforth
Yeah, I was surprised, too. I can see the low level touch events being generated and passed up to the Java code, but I haven't actually verified yet that it turns them into JavaFX TouchEvents that get delivered to an application (I'll try that this afternoon). -- Kevin On 1/30/2020 10:55 AM,

Re: How to build standalone openJFX modules for uploading to a local maven repository

2020-01-30 Thread Matthias Bläsing
Hi Danny, Am Dienstag, den 28.01.2020, 09:50 + schrieb Danny Gonzalez: > We have a java 11 project that uses maven to pull in openJFX > modules i.e. javafx-controls, javafx-web, javafx-swing. > > What we would like to do is build our own versions of these openJFX > modules for use as maven d

Re: Scary keystroke logging dialog on macOS 10.15 Catalina (JDK-8231513)

2020-01-30 Thread Michael Paus
In this case I would also vote for #2. Your comment astonishes me nevertheless because I have never received any JavaFX TouchEvents on my Mac, so I won't miss them. As far as I know they are only generated by real touch screens but NOT by track pads, or have I missed something here? This is also

Re: Scary keystroke logging dialog on macOS 10.15 Catalina (JDK-8231513)

2020-01-30 Thread Kevin Rushforth
This affects TouchEvents generated via low-level native touch events, including those generated by a trackpad. GestureEvents still work. In particular, the HelloGestures app still works: even with low-level touch events disabled, I can use the trackpad to rotate and zoom and the app picks it up

Re: Scary keystroke logging dialog on macOS 10.15 Catalina (JDK-8231513)

2020-01-30 Thread Michael Paus
Just to clarify the implications of this issue: Are you only talking about the JavaFX TouchEvents or would disabling them also affect all GestureEvents and synthesized MouseEvents when you are working with a trackpad? Am 30.01.20 um 17:47 schrieb Kevin Rushforth: To: Mac app developers / users

Re: Scary keystroke logging dialog on macOS 10.15 Catalina (JDK-8231513)

2020-01-30 Thread Sebastian Stenzel
> To: Mac app developers / users > > I started looking into JDK-8231513 [1] -- "JavaFX cause Keystroke Receiving > prompt on MacOS 10.15 (Catalina)" -- a couple days ago. The effect of this > bug is that a scary dialog is shown for all users the first time they run a > JavaFX application and

Re: [EXTERNAL] Explanation of different scaling factors anywhere?

2020-01-30 Thread Michael Paus
I am wondering whether this kind of scaling should actually be done on an application basis. On desktop computers this is normally achieved via some system setting of the monitor scaling. I think most people just want a consistent scaling across all applications and so there is just no need in gen

Scary keystroke logging dialog on macOS 10.15 Catalina (JDK-8231513)

2020-01-30 Thread Kevin Rushforth
To: Mac app developers / users I started looking into JDK-8231513 [1] -- "JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)" -- a couple days ago. The effect of this bug is that a scary dialog is shown for all users the first time they run a JavaFX application and move the mous

Windows: Mnemonics Issue

2020-01-30 Thread Abhinay Agarwal
On Windows, mnemonics is activated when ALT is pressed. This is true for apps made in JavaFX. However I have found the following discrepancy between Windows Native Apps and JavaFX apps: In Windows, pressing any key(not assigned to mnemonics) in combination with ALT doesn't de-activates mnemoni

Re: [EXTERNAL] Explanation of different scaling factors anywhere?

2020-01-30 Thread Mike Hearn
Yes, a scale transform doesn't affect layout. That's the issue. Browser zoom scales fonts, images and widgets but in a way that affects layout bounds, not only render bounds. As far as I can tell there's no way to do a zoom or scale that affects layout bounds with the public JavaFX API. Exploring

Re: Should Skara tooling invalidate approvals when new commits are pushed? [was: RFR: 8130738: Add tabSize property to Text and TextFlow]

2020-01-30 Thread Kevin Rushforth
Hearing no objections, we will enable this for pull requests on the jfx repo starting Tuesday, Feb 4. -- Kevin On 1/8/2020 11:34 AM, Kevin Rushforth wrote: Does anyone strongly feel otherwise? If not, then I'll request the Skara team to enable this feature. -- Kevin On 1/8/2020 11:26 AM,

Re: [Rev 04] RFR: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size

2020-01-30 Thread Ambarish Rapte
On Thu, 30 Jan 2020 08:15:48 GMT, Frederic Thevenet wrote: >> This PR aims to address the following issue: JDK-8088198 Exception thrown >> from snapshot if dimensions are larger than max texture size >> >> In order to do that, it simply captures snapshots in multiple tiles of >> maxTextureSiz