Re: Memory leak issues related to 2 PRs in OpenJFX

Hi Kevin, I found the problem with this, and I've pushed a small commit to my fork which I think reproduces the behavior I described [1]. Per comments in the code, to run the test you'll need to make the ControlsFX library v11 available to the build, sorry I didn't do that myself but I'm not f

Re: RFR: 8237453: [TabPane] Incorrect arrow key traversal through tabs after reordering

On Wed, 5 Feb 2020 23:31:29 GMT, Kevin Rushforth wrote: >> Issue: >> Dragging a tab and dropping it back to it's original position causes an >> incorrect reordering of tabs. Incorrect order of tabs can be observed using >> arrow key traversal through tabs. >> >> Cause: >> Below mechanism of i

Re: RFR: 8237453: [TabPane] Incorrect arrow key traversal through tabs after reordering

On Wed, 5 Feb 2020 11:07:39 GMT, Ambarish Rapte wrote: > Issue: > Dragging a tab and dropping it back to it's original position causes an > incorrect reordering of tabs. Incorrect order of tabs can be observed using > arrow key traversal through tabs. > > Cause: > Below mechanism of identifyi

Re: RFR: 8227619: Potential memory leak in javafx.scene.control.ListView

On Fri, 10 Jan 2020 08:17:12 GMT, Ambarish Rapte wrote: > `ListView` does not get GCed because `SelectedItemsReadOnlyObservableList` > adds a `ListChangeListener` to the (`ObservableList`) items of `ListView`. > > Adding a `WeakListChangeListener` instead of `ListChangeListener` fixes the > is

Re: [Rev 01] RFR: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface

On Wed, 5 Feb 2020 22:50:59 GMT, Ambarish Rapte wrote: >> The finalize() method is deprecated in JDK9. See [Java 9 deprecated >> features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html). >> And so the >> [PiscesRenderer.finalize()](https://github.com/openjdk/

Re: RFR: 8236839: System menubar removed when other menubars are created or modified

On Tue, 14 Jan 2020 19:50:28 GMT, Johan Kaving wrote: > This pull request fixes the sceneProperty listener in `MenuBarSkin` so that > we leave the > current system menubar alone when other menubars are changed. > > It also adds a test case that reproduces the problem before the fix. This look

Re: Additional Information to JDK-8150263 ObservableListWrapper

Thanks Peter, I added the info. - Nir On Wed, Feb 5, 2020 at 9:55 AM Peter, Benjamin wrote: > Hi devs, > > about JDK-8150263 : ObservableListWrapper fires change notifications from > sort() and sort(Comparator) even if list is not changed. > > I stumbled about the problem and prepared a minimal

Re: set Destination attribute in printReqAttrSet

Awesome :) good to know that is in WIP state. Really looking forward for it. Good luck in solving the bugs! ^_^ Cristian-Stefan On Wed, Feb 5, 2020 at 2:16 AM Philip Race wrote: > I found that there were some bugs in the JDK code that FX calls > that need to be fixed first. I started on those b

Re: [Rev 03] RFR: 8217472: Add attenuation for PointLight

On Fri, 10 Jan 2020 00:34:18 GMT, Kevin Rushforth wrote: >>> This will need a fair bit of testing to ensure that there are no >>> regressions either in functionality or (especially) performance, in >>> addition to tests for the new functionality. >> >> Which tests for the new functionality sho

RFR: 8237453: [TabPane] Incorrect arrow key traversal through tabs after reordering

Issue: Dragging a tab and dropping it back to it's original position causes an incorrect reordering of tabs. Incorrect order of tabs can be observed using arrow key traversal through tabs. Cause: Below mechanism of identifying if tab header is dragged and dropped at same position is not reliab