Re: [Rev 27] RFR: 8236651: Simplify and update glass gtk backend

2020-02-15 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: RFR: 8196586: Remove use of deprecated finalize methods from javafx property objects

2020-02-15 Thread Nir Lisker
On Fri, 14 Feb 2020 20:47:04 GMT, Nir Lisker wrote: >> @arapte I request you to be one of the reviewers of this PR. > > I'll be the 2nd reviewer. > the referent to the created property object has been garbage collected before > the `finalize` method is called I'm confused. What is that

Re: Re: "Using an IDE" Page outdated (Openjfx)

2020-02-15 Thread Eric Bresie
Wanted to ping the netbeans mailing list to see if there is any input that could be provided to help on the open jfx as it relates to recent netbeans.. See https://wiki.openjdk.java.net/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingNetBeans(JDK-8) I seem to recall sometime back that there was

Re: RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

2020-02-15 Thread Kevin Rushforth
On Fri, 14 Feb 2020 14:27:15 GMT, Jeanette Winzenburg wrote: >> To add multiple comments, go to the `Files changed` tab and click on a line >> of code to add a comment there. Select `Start a review` rather than `Add >> single comment`. This way you can batch up multiple comments. Then you >>

Re: RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

2020-02-15 Thread Kevin Rushforth
On Fri, 14 Feb 2020 09:09:13 GMT, Ajit Ghaisas wrote: > Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 > > Fix : Added the missed out RTL checks to the key mappings in > TableViewBehaviorBase class. > > Testing : Modified unit tests in TableViewKeyInputTest to take orientation as > a