Re: RFR: 8196586: Remove use of deprecated finalize methods from javafx property objects

2020-02-19 Thread Nir Lisker
On Tue, 18 Feb 2020 20:09:59 GMT, Kevin Rushforth wrote: >>> the referent to the created property object has been garbage collected >>> before the `finalize` method is called >> >> I'm confused. What is that referent exactly and why is it guaranteed to have >> been GC'd before finalization? >

Re: RFR: 8239109: Update SQLite to version 3.31.1

2020-02-19 Thread Arun Joseph
On Thu, 20 Feb 2020 05:58:03 GMT, Guru Hb wrote: > Updating SQLite to version 3.31.1 (Currently used version is 3.30.1). Marked as reviewed by ajoseph (Author). - PR: https://git.openjdk.java.net/jfx/pull/119

RFR: 8239109: Update SQLite to version 3.31.1

2020-02-19 Thread Guru Hb
Updating SQLite to version 3.31.1 (Currently used version is 3.30.1). - Commits: - d4e17340: 8239109: Update SQLite to version 3.31.1 Changes: https://git.openjdk.java.net/jfx/pull/119/files Webrev: https://webrevs.openjdk.java.net/jfx/119/webrev.00 Issue: https://bugs.openjdk.ja

Re: [Integrated] RFR: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions

2020-02-19 Thread Guru Hb
Changeset: d8e7f850 Author:Arun Joseph Committer: Guru Hb Date: 2020-02-20 05:33:04 + URL: https://git.openjdk.java.net/jfx/commit/d8e7f850 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions Reviewed-by: ghb, kcr ! modules/javafx.web/src/main/na

RFR: 8239513: Update SQLite to version 3.31.1

2020-02-19 Thread Guru Hb
Updating SQlite to 3.31.1 (Currently used 3.30.1). - Commits: - e8312460: 8239513: Update SQLite to version 3.31.1 Changes: https://git.openjdk.java.net/jfx/pull/118/files Webrev: https://webrevs.openjdk.java.net/jfx/118/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8

Re: RFR: 8176499: Dependence on java.util.Timer freezes screen when OS time resets backwards

2020-02-19 Thread Dell Green
On Wed, 19 Feb 2020 19:39:30 GMT, Kevin Rushforth wrote: >> I don't see any stray commits, so it looks like your branch is based off of >> master correctly. >> >> One thing I would ask you to change is that the title of this PR should >> exactly match the title of the JBS bug. So can you chang

Re: Question ad running the "systemTests" module tests ...

2020-02-19 Thread Kevin Rushforth
First, make sure that your test class name ends with exactly the string "Test". As I think you noticed, the systemTests project is only run if the `FULL_TEST` property is set to `true`, like this: gradle -PFULL_TEST=true test If you just want to run the system tests: gradle -PFULL_TEST=true

Re: RFR: 8176499: Remove MonocleTimer dependency on system time

2020-02-19 Thread Kevin Rushforth
On Wed, 19 Feb 2020 19:37:41 GMT, Kevin Rushforth wrote: >> @kevinrushforth apologies for previous, my local repos seem to be messed up >> when i changed remotes from old javafx github repo to new one, as that rogue >> commit didnt exist my side for some reason. looks like its fixed now > > I

Re: RFR: 8176499: Remove MonocleTimer dependency on system time

2020-02-19 Thread Kevin Rushforth
On Wed, 19 Feb 2020 19:17:03 GMT, Dell Green wrote: >> https://bugs.openjdk.java.net/browse/JDK-8176499 >> >> This pull request fixes a long standing issue in the MonocleTimer class >> whereby it has a dependency on the java.uti.Timer class which is dependent >> on system time and can cause U

Re: RFR: 8176499: Remove MonocleTimer dependency on system time

2020-02-19 Thread Dell Green
On Wed, 19 Feb 2020 19:14:08 GMT, Dell Green wrote: > https://bugs.openjdk.java.net/browse/JDK-8176499 > > This pull request fixes a long standing issue in the MonocleTimer class > whereby it has a dependency on the java.uti.Timer class which is dependent on > system time and can cause UI fre

RFR: 8176499: Remove MonocleTimer dependency on system time

2020-02-19 Thread Dell Green
https://bugs.openjdk.java.net/browse/JDK-8176499 This pull request fixes a long standing issue in the MonocleTimer class whereby it has a dependency on the java.uti.Timer class which is dependent on system time and can cause UI freezes for seconds/minutes/hours/days/years dependent upon how far

Question ad running the "systemTests" module tests ...

2020-02-19 Thread Rony G. Flatscher
"build.gradle" contains the project ":systemTests" which defines tests that each run on a separate JVM and use their own Assert methods defined in respective Util.java. They signal success according to the values defined in "Constants.java". The module test "testapp7" that I wrote mimickries the

Re: RFR: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions

2020-02-19 Thread Kevin Rushforth
On Wed, 19 Feb 2020 12:09:50 GMT, Arun Joseph wrote: > With new bytecode format introduced in Webkit 608.1, the unlinked and linked > bytecodes were replaced by narrow (1-byte operand) and wide (4-byte operand) > bytecodes. These were extended to narrow, wide16 and wide32 bytecodes in > WebKit

Re: RFR: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions

2020-02-19 Thread Guru Hb
On Wed, 19 Feb 2020 12:09:50 GMT, Arun Joseph wrote: > With new bytecode format introduced in Webkit 608.1, the unlinked and linked > bytecodes were replaced by narrow (1-byte operand) and wide (4-byte operand) > bytecodes. These were extended to narrow, wide16 and wide32 bytecodes in > WebKit

Re: [Integrated] RFR: 8228867: Fix mistakes in FX API docs

2020-02-19 Thread Nir Lisker
Changeset: 35a01caf Author:Nir Lisker Date: 2020-02-19 14:35:56 + URL: https://git.openjdk.java.net/jfx/commit/35a01caf 8228867: Fix mistakes in FX API docs Reviewed-by: jvos, kcr ! modules/javafx.base/src/main/java/javafx/collections/FXCollections.java ! modules/javafx.graph

Re: [jfx14] [Rev 02] RFR: 8228867: Fix mistakes in FX API docs

2020-02-19 Thread Johan Vos
On Tue, 18 Feb 2020 21:59:07 GMT, Nir Lisker wrote: >> Docs fixes for OpenJFX 14. We can wait with integrating this in case there >> are last minute fixes, but reviews can start. > > The pull request has been updated with 2 additional commits. Marked as reviewed by jvos (Reviewer). --

Re: [Rev 02] RFR: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface

2020-02-19 Thread Johan Vos
On Mon, 10 Feb 2020 13:33:41 GMT, Ambarish Rapte wrote: >> The finalize() method is deprecated in JDK9. See [Java 9 deprecated >> features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html). >> And so the >> [PiscesRenderer.finalize()](https://github.com/openjdk

RFR: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions

2020-02-19 Thread Arun Joseph
With new bytecode format introduced in Webkit 608.1, the unlinked and linked bytecodes were replaced by narrow (1-byte operand) and wide (4-byte operand) bytecodes. These were extended to narrow, wide16 and wide32 bytecodes in WebKit 609.1. In narrow instructions, each argument of the opcode has

Re: RFR: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation

2020-02-19 Thread Ajit Ghaisas
On Sat, 15 Feb 2020 14:54:50 GMT, Kevin Rushforth wrote: >> thanks, Kevin - that's what I tried, but it refused to accept the second .. >> so sticking with single comments until I feel like digging into this >> weirdness. > > Regarding the fix, it seems that you need to eliminate the `rtl` var