Re: [Rev 03] RFR: 8217472: Add attenuation for PointLight

2020-02-21 Thread Nir Lisker
On Mon, 17 Feb 2020 01:53:18 GMT, Nir Lisker wrote: >> Looks like the `jcheck` bot removed the `rfr` label because the CSR isn't >> complete. An incomplete CSR should be treated the same way as an >> insufficient number of reviewers. I filed >> [SKARA-262](https://bugs.openjdk.java.net/browse/

Re: [Rev 03] RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-21 Thread Alexander Matveev
On Thu, 20 Feb 2020 12:19:07 GMT, Johan Vos wrote: >> * add support for the "resource" protocol (which is used in the GraalVM URLs >> pointing to statically bundled resources) >> * avoid duplicate symbols with different gst plugins >> * statically register gst plugins > > The pull request has b

Re: Monocle as a replacement

2020-02-21 Thread Tres Finocchiaro
Danny, Thanks this information is very valuable. By using the provided patch, I too am able to re-use the Monocle framework without suffering this bug. For those visiting this thread (e.g. through archive) at a later time, it's being tracked downstream here: https://github.com/qzind/tray/issues/

Re: [Rev 01] RFR: 8237889: Update libxml2 to version 2.9.10

2020-02-21 Thread Kevin Rushforth
On Fri, 21 Feb 2020 06:33:02 GMT, Arun Joseph wrote: >> We currently use libxml2 version 2.9.9. We should update to the latest >> stable release 2.9.10. > > The pull request has been updated with 1 additional commit. Looks good. I did a full build / test on Windows, and a full build on Mac and

Re: RFR: 8239513: Update SQLite to version 3.31.1

2020-02-21 Thread Nir Lisker
On Thu, 20 Feb 2020 05:15:25 GMT, Guru Hb wrote: > Updating SQlite to 3.31.1 (Currently used 3.30.1). @rwestberg When the author closes their PR, shouldn't the bot remove the `rfr` label? - PR: https://git.openjdk.java.net/jfx/pull/118

Re: PixelBuffer API threading model?

2020-02-21 Thread Kevin Rushforth
I missed seeing this yesterday. Since you have a test program, can you file a bug at: https://bugreport.java.com/ and include your test case? Thanks. -- Kevin On 2/21/2020 3:17 AM, Neil C Smith wrote: Hi, On Tue, 18 Feb 2020 at 13:09, Neil C Smith wrote: the new JavaFX PixelBuffer API

Re: [Rev 03] RFR: 8238755: allow to create static lib for javafx.media on linux

2020-02-21 Thread Johan Vos
On Thu, 20 Feb 2020 21:55:37 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 4 additional commits. > > modules/javafx.base/src/main/java/com/sun/javafx/PlatformUtil.java line 74: > >> 73: private static final boolean IOS = os.startsWith("iOS"); >> 74: private stati

Re: PixelBuffer API threading model?

2020-02-21 Thread Neil C Smith
Hi, On Tue, 18 Feb 2020 at 13:09, Neil C Smith wrote: > the new JavaFX PixelBuffer API ... > will result in occasional access attempts and segfaults in texture upload. Is this the wrong place to discuss the documentation and/or enhancement to the implementation of the PixelBuffer API? I have a