> ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which results
> in leaking the `ButtonSkin` itself when
> the `Button`'s skin is changed to a new `ButtonSkin`. Using a
> `WeakChangeListener` instead of `ChangeListener` solves
> the issue.
> Please take a look.
Ambarish Rapte h
On Fri, 27 Mar 2020 12:12:30 GMT, Ambarish Rapte wrote:
>> In general, there are two approaches to avoiding listener-related memory
>> leaks. One is to use a WeakListener; the other
>> is to explicitly remove the listener when the object is removed or otherwise
>> no longer needed.
>> Using a W
On Fri, 27 Mar 2020 21:17:04 GMT, Nir Lisker wrote:
>> Marked as reviewed by jvos (Reviewer).
>
>> We will continue to generate class files using `-source 11 -target 11`
>
> Isn't `-release 11` the preferred way?
gradle's java plugin translates `sourceCompatibility NN` into `-source NN
-target
On Fri, 27 Mar 2020 17:10:09 GMT, Johan Vos wrote:
>> Now that we have switched to using gradle 6.3 we can switch to using JDK 14
>> as the boot JDK for JavaFX 15 builds.
>>
>> This will not change the minimum JDK version needed to build or run JavaFX,
>> which remains at 11. We will continue
On Thu, 26 Mar 2020 18:46:15 GMT, Kevin Rushforth wrote:
> Now that we have switched to using gradle 6.3 we can switch to using JDK 14
> as the boot JDK for JavaFX 15 builds.
>
> This will not change the minimum JDK version needed to build or run JavaFX,
> which remains at 11. We will continue
Zitat von Nir Lisker :
BTW, Tomas Mikula wrote about this on
http://tomasmikula.github.io/blog/2015/02/10/the-trouble-with-weak-listeners.html
.
There is a comment at the end that is worth a read too.
also interesting is the old (closed as wontfix) bug
https://bugs.openjdk.java.net/browse/
On Mon, 23 Mar 2020 23:40:39 GMT, Kevin Rushforth wrote:
>
>
> Using a WeakListener is certainly easier, but runs the risk of the listener
> being removed too early and not cleaning up
> after itself. I'm not suggesting that's the case here, but it is worth
> looking at.
The listener does n
> ChoiceBox leaves a memory leak when replacing the selectionModel. Culprit is
> ChoiceBoxSelectionModel which registers
> listener with strong references. Fix is to change these to weak references.
> Added test that fails before and passes after the test.
>
> for convenience, the bug reference
