Re: CFV: New OpenJFX Committer: Arun Joseph

2020-03-31 Thread Prasanta Sadhukhan
Vote: YES Regards Prasanta On 26-Mar-20 5:14 PM, Kevin Rushforth wrote: I hereby nominate Arun Joseph [1] to OpenJFX Committer. Arun is a member of JavaFX team at Oracle, who has contributed 13 commits [2][3] to OpenJFX. Votes are due by April 9, 2020. Only current OpenJFX Committers [4] ar

Re: CFV: New OpenJFX Committer: Arun Joseph

2020-03-31 Thread Ajit Ghaisas
Vote: YES Regards, Ajit > On 26-Mar-2020, at 5:14 PM, Kevin Rushforth > wrote: > > I hereby nominate Arun Joseph [1] to OpenJFX Committer. > > Arun is a member of JavaFX team at Oracle, who has contributed 13 commits > [2][3] to OpenJFX. > > Votes are due by April 9, 2020. > > Only current

Re: CFV: New OpenJFX Committer: Arun Joseph

2020-03-31 Thread Guru
Vote: YES > On 26-Mar-2020, at 5:14 PM, Kevin Rushforth > wrote: > > I hereby nominate Arun Joseph [1] to OpenJFX Committer. > > Arun is a member of JavaFX team at Oracle, who has contributed 13 commits > [2][3] to OpenJFX. > > Votes are due by April 9, 2020. > > Only current OpenJFX Commit

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
On Tue, 24 Mar 2020 13:33:33 GMT, Thiago Milczarek Sayao wrote: >> I have been testing this for several days on ubuntu 18.04 and it's working >> good. It pass system tests, runs Ensemble 8 >> and Scenebuilder. >> Will have to do some tests on 16.04. > > Ubuntu 20.04 Test Results > > Updated 31

Re: [Rev 37] RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 36] RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 35] RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 34] RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 33] RFR: 8236651: Simplify and update glass gtk backend

2020-03-31 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward co

Re: [Rev 02] RFR: 8241476: Linux build warning issued on updated compilers (Ubuntu 18.04.4 / 20.04)

2020-03-31 Thread Thiago Milczarek Sayao
On Thu, 26 Mar 2020 11:21:06 GMT, Kevin Rushforth wrote: >> I think it's better to split the flags between CFLAGS and CPPFLAGS (as is >> done in OpenJDK). The >> `-Werror=implicit-function-declaration` is extremely useful for C files, and >> we don't want to risk that this somehow >> got lost.

Re: Seeking help with latest master ...

2020-03-31 Thread Rony G. Flatscher
On 31.03.2020 20:21, Scott Palmer wrote: >> Could not resolve all dependencies for configuration ':apps:lucene'. >   > Multiple build operations failed. >     java.lang.ExceptionInInitializerError >     java.lang.NoClassDefFoundError: Could not initialize class >    sun.security

Re: Seeking help with latest master ...

2020-03-31 Thread Scott Palmer
> Could not resolve all dependencies for configuration ':apps:lucene'. > Multiple build operations failed. java.lang.ExceptionInInitializerError java.lang.NoClassDefFoundError: Could not initialize class sun.security.ssl.SSLContextImpl$TLSContext java.la

Re: Seeking help with latest master ...

2020-03-31 Thread Rony G. Flatscher
On 31.03.2020 19:10, Kevin Rushforth wrote: > That's not the problem. The minimum build number only applies if at the exact > minimum JDK version > in question. You are using 11.0.6 which is > 11 so no problem there. > > One last thing to try: > > $ rm -rf .gradle buildSrc/.gradle buildSrc/build >

Re: Seeking help with latest master ...

2020-03-31 Thread Kevin Rushforth
That's not the problem. The minimum build number only applies if at the exact minimum JDK version in question. You are using 11.0.6 which is > 11 so no problem there. One last thing to try: $ rm -rf .gradle buildSrc/.gradle buildSrc/build In case something is cached there that the newer gradl

Re: Seeking help with latest master ...

2020-03-31 Thread Rony G. Flatscher
Hmm, noticed a JDK  "minimum jdk build number: 28" minimum build number. Currently using the latest AdoptOpenJDK 11 LTS. If that is the problem which JDK would you suggest to use instead? ---rony On 31.03.2020 18:51, Rony G. Flatscher wrote: > On 31.03.2020 18:20, Kevin Rushforth wrote: >> Che

Re: Seeking help with latest master ...

2020-03-31 Thread Rony G. Flatscher
On 31.03.2020 18:20, Kevin Rushforth wrote: > Check your JDK version and gradle version: > > $ java -version > $ gradle -version > > If they look OK, you might try: > > $ rm -rf build > $ gradle clean > > and then do a build. Thank you, Kevin, unfortunately, it does not work out (it fails at "grad

Re: Seeking help with latest master ...

2020-03-31 Thread Kevin Rushforth
Check your JDK version and gradle version: $ java -version $ gradle -version If they look OK, you might try: $ rm -rf build $ gradle clean and then do a build. -- Kevin On 3/31/2020 8:06 AM, Rony G. Flatscher wrote: After merging the master into a local branch, gradle fails with two except

Seeking help with latest master ...

2020-03-31 Thread Rony G. Flatscher
After merging the master into a local branch, gradle fails with two exceptions. After updating to 6.3 it still fails, here the output: rony@rony-linux:~/dev/github/openjdk/jfx$ gradle --stop Stopping Daemon(s) 1 Daemon stopped rony@rony-linux:~/dev/github/openjdk/jfx$ gradle

Re: [Rev 04] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-31 Thread Rony G . Flatscher
On Tue, 31 Mar 2020 11:52:19 GMT, Ajit Ghaisas wrote: >> Rony G. Flatscher has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove jcheck whitespace error. > > Marked as reviewed by aghaisas (Reviewer). Kevin, Ajit, could you please /spo

Re: [Rev 04] RFR: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV

2020-03-31 Thread Ajit Ghaisas
On Wed, 25 Mar 2020 19:05:42 GMT, Rony G. Flatscher wrote: >> …9: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV > > Rony G. Flatscher has updated the pull request incrementally with one > additional commit since the last revision: > > Remove jcheck whitespace erro