Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing

2020-04-21 Thread Abhinay Agarwal
On Sat, 11 Apr 2020 09:53:46 GMT, Ambarish Rapte wrote: > The issue occurs because the key events are consumed by the `ListView` in > `Popup`, which displays the items. > This is a regression of > [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change > aadded several > `

Re: RFR: 8241582: Infinite animation does not start from the end when started with a negative rate

2020-04-21 Thread Kevin Rushforth
On Fri, 10 Apr 2020 06:31:39 GMT, Nir Lisker wrote: > ### Cause > > `Animation#jumpTo(Duration)` does not handle `Duration.INDEFINITE` properly. > This causes > `InfiniteClipEnvelope#jumpTo(long)` to receive an erroneous value and start > the animation not from the end, depending > on the modu

Re: [Rev 01] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-21 Thread Kevin Rushforth
On Sun, 19 Apr 2020 09:34:00 GMT, Jesper Skov wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/ToggleButton.java >> line 196: >> >>> 195: private ObjectProperty toggleGroup; >>> 196: @Override >>> 197: public final void setToggleGroup(ToggleGroup value) { >> >>

Re: RFR: 8242077: Add information about HTTP/2 and HttpClient usage in WebEngine

2020-04-21 Thread Kevin Rushforth
On Sun, 19 Apr 2020 08:12:07 GMT, Abhinay Agarwal wrote: > Update WebEngine's Javadoc to add information on how it switches to > HttpClient instead of URLConnection in JavaFX 14 > when used with JDK 12 or later. > Identification the correct client is important as both these clients may > offer

Re: RFR: 8193286: IntegerSpinnerFactory does not wrap value correctly

2020-04-21 Thread Kevin Rushforth
On Mon, 13 Apr 2020 06:59:08 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8193286 > > Root Cause : > Incorrect implementation. > Current implementation of int wrapValue(int,int,int) in Spinner.java works > well if min is 0. > Hence this implementation works with L

Re: RFR: 8191758: Match WebKit's font weight rendering with JavaFX

2020-04-21 Thread Bhawesh Choudhary
On Fri, 17 Apr 2020 18:06:06 GMT, Phil Race wrote: >> Can you add a unit test to go along with this fix? > > Per the opentype spec, 700 is bold. 600 is semi-bold > https://docs.microsoft.com/en-us/typography/opentype/spec/os2#usweightclass > > CSS agrees : https://developer.mozilla.org/en-US/doc

Re: Re: Remove JavaFX JPMS enforcement

2020-04-21 Thread Steve Hannah
Personally, the lack of a "just add these jars to your classpath" install option is a big enough pain point that I avoid dependence on JavaFX as much as possible. Many of the things I develop are distributed as jar files and the requirements are (JDK8+). If I use JavaFX the requirements change t

RFR: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi

2020-04-21 Thread Alexander Scherbatiy
See the detailed issue description on: http://mail.openjdk.java.net/pipermail/openjfx-dev/2020-April/025975.html The fix 8236448 https://github.com/openjdk/jfx/pull/75 changes [MonocleApplication.staticScreen_getScreens()](https://github.com/openjdk/jfx/pull/75/files#diff-b66ff7fe72c6c5cd26003572

Re: [Rev 02] RFR: 8191758: Match WebKit's font weight rendering with JavaFX

2020-04-21 Thread Bhawesh Choudhary
> As per JavaFx 700 font weight is considered to be bold but webkit is using > 600 font weight for text to become bold. to > fix issue, use boldWeightValue() function which uses 700 font weight rather > than isFontWeightBold() which compare > against 600 font weight. Bhawesh Choudhary has refres

Re: Re: Remove JavaFX JPMS enforcement

2020-04-21 Thread Eric Bresie
Thought I would provide a few references (1,2,3,4,5) on JPMS over time with a few pros and cons embedded within them . Maybe some will be of help. (1) https://blog.joda.org/2018/03/jpms-negative-benefits.html?m=1 (2) https://jaxenter.com/java-9-modules-jpms-basics-135885.html (3) http://mail

Re: JavaFX controls have large size on Raspberry Pi

2020-04-21 Thread thomas.manz+JFX
I debugged this topic already last week and what I saw was that this was still working with release 13 and now in 14 it´s broken. I guess the problem was introduced with the change “8236448: Remove unused and repair broken Android/Dalvik code” (https://github.com/openjdk/jfx/pull/75) where the f

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2020-04-21 Thread Kevin Rushforth
On Thu, 2 Apr 2020 17:37:26 GMT, Dalibor Topic wrote: >> https://bugs.openjdk.java.net/browse/JDK-8197991 >> >> The performance of the selectAll and selectRange methods of the >> MultiSelectionModel class has been greatly improved. >> >> This greatly improves the response when selecting multip

Re: RFR: 8242548: Honor line spacing in Labeled reflow calculation

2020-04-21 Thread Kevin Rushforth
On Tue, 14 Apr 2020 11:41:22 GMT, Kevin Rushforth wrote: >> This is a solution for 8242548. There was zero test coverage, so I added a >> few tests for this as well. > > @aghaisas can you review this? @aghaisas can you also review this? - PR: https://git.openjdk.java.net/jfx/pull

Re: RFR: 8087555: [ChoiceBox] uncontained value not shown

2020-04-21 Thread Kevin Rushforth
On Mon, 20 Apr 2020 12:23:16 GMT, Jeanette Winzenburg wrote: > The issue is that ChoiceBoxSkin > a) doesn't update the text of the label if the value is not contained in the > items > b) doesn't respect converter for label text > > Fixed by > - listening to value changes to update the label >

Re: Ad GraalVM and JavaFX (Re: Remove JavaFX JPMS enforcement

2020-04-21 Thread Rony G. Flatscher
Hi Michael, thank you very much for sharing this link, which is very interesting! Reading the limitation section is interesting and also reveals current assumptions of the GraalVM developers that may not meet reality in full, hence making it a little bit cumbersome/difficult to fully support it

Re: Remove JavaFX JPMS enforcement

2020-04-21 Thread Mike Hearn
Maybe openjfx.io needs more maintainers? I opened a PR against that repo some days ago and it's not been looked at. The JavaFX docs are certainly a weak point right now, given that the Java 8 era docs aren't really being maintained, and aren't open source, and the main docsite isn't really actively

Re: Proposed IntegerSpinner buggy behavior correction - JDK-8242553

2020-04-21 Thread Jeanette Winzenburg
part of the confusion might be the reporter's workaround in https://bugs.openjdk.java.net/browse/JDK-8193286 which effectively clamps (doesn't make a difference, having amountPerStep=1 and not incrementing programatically) commented that bug with an alternative implemenation and a couple

Re: [Rev 01] RFR: 8191758: Match WebKit's font weight rendering with JavaFX

2020-04-21 Thread Bhawesh Choudhary
> As per JavaFx 700 font weight is considered to be bold but webkit is using > 600 font weight for text to become bold. to > fix issue, use boldWeightValue() function which uses 700 font weight rather > than isFontWeightBold() which compare > against 600 font weight. Bhawesh Choudhary has update