Re: RFR: 8243115: Spurious invalidations due to bug in IntegerBinding and other classes

2020-05-11 Thread Nir Lisker
On Tue, 28 Apr 2020 00:00:28 GMT, Kevin Rushforth wrote: >> I will review this too anyway. > >> I will review this too anyway. > > Thank you. That will be helpful. As I started my review I noticed that `unbind` does not null-check its argument `dependencies` like `bind` does and it can lead

Re: [Integrated] RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3

2020-05-11 Thread Kevin Rushforth
On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth wrote: > This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 > (version 16.5.3). This will match a recent upgrade done for JDK 15 -- see >

Re: [Integrated] RFR: 8244487: One Windows 10 SDK file missing from FX build

2020-05-11 Thread Kevin Rushforth
On Wed, 6 May 2020 17:34:39 GMT, Kevin Rushforth wrote: > While auditing the list of redistributed Microsoft files in the JDK versus > FX, I discovered one file that the JDK ships > that FX does not: > api-ms-win-core-console-l1-2-0.dll > > I checked the Redist directory in the Windows 10 SDK

Re: [Rev 04] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-05-11 Thread Nir Lisker
On Tue, 17 Mar 2020 11:43:16 GMT, Frederic Thevenet wrote: >> Issue JDK-8088198, where an exception would be thrown when trying to capture >> a snapshot whose final dimensions would be >> larger than the running platform's maximum supported texture size, was >> addressed in openjfx14. The

Re: backport request: JDK-8200224

2020-05-11 Thread Kevin Rushforth
+1 -- Kevin On 5/11/2020 7:39 AM, Johan Vos wrote: Hi Kevin, I ask permission to backport JDK-8200224 (Multiple press event when JFXPanel gains focus) to JavaFX 11-dev Thanks, - Johan

backport request: JDK-8200224

2020-05-11 Thread Johan Vos
Hi Kevin, I ask permission to backport JDK-8200224 (Multiple press event when JFXPanel gains focus) to JavaFX 11-dev Thanks, - Johan

Re: Mac: Supported MacOS JDKs

2020-05-11 Thread Kevin Rushforth
I built FX with Xcode 11.3.1 + MacOSX10.15.sdk last week and it works fine for me. -- Kevin On 5/10/2020 7:05 AM, Nir Lisker wrote: if this is confirmed I can update the page. On Tue, Apr 14, 2020 at 1:18 PM Florian Kirmaier wrote: Hi everyone, it seems to me, that the newest JDK for

RFR: 8244735: Error on iOS passing keys with unicode values greater than 255

2020-05-11 Thread Jose Pereda
With this PR, we pass directly the 16-bit unsigned short for a character (unicode value) to the Java layer, avoiding the cast with the C++ 8-bit char, that fails for non-ascii characters like euro (€) or quote ("). We also avoid the mapping between iOS keys and JavaFX `KeyCode`, except for

Re: Next steps ? (Re: An attempt of a CSR draft ... (Re: A new WIP (PR # 192) (Re: WIP version with PI compile (Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLL

2020-05-11 Thread Rony G. Flatscher
Hi Kevin, On 09.05.2020 17:16, Kevin Rushforth wrote: > I'm finally getting back to this. I took a look at > https://github.com/openjdk/jfx/pull/192 and I > like that as the direction for this enhancement. > > The initial CSR you have is a good start. Thank you! > Next steps are: > > 1. Update

Re: Questions ad JavaScript in JavaFX' WebEngine

2020-05-11 Thread Rony G. Flatscher
On 09.05.2020 17:23, Kevin Rushforth wrote: > WebEngine uses WebKit's JavaScriptCore as its JavaScript engine. The sources > are in the jfx repo, > along with the JavaFX-specific classes that implement the two-way Java <--> > JavaScript bridge. > Other than the public API docs for WebEngine,