RFR: 8244824: TableView : Incorrect German translation

2020-05-14 Thread Ajit Ghaisas
Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 Fix : As simple as it gets !!! - Commit messages: - German translation bug fix Changes: https://git.openjdk.java.net/jfx/pull/220/files Webrev: https://webrevs.openjdk.java.net/jfx/220/webrev.00 Issue: https://bugs.openjdk

Re: [Integrated] RFR: 8244112: Skin implementations: must not violate contract of dispose

2020-05-14 Thread Jeanette Winzenburg
On Wed, 6 May 2020 11:16:50 GMT, Jeanette Winzenburg wrote: > some skins have not been guarding themselves against multiple calls to > dispose (see issue for details) > > Fixed by backing out off dispose if skinnable is null. Added test > (parameterized in control class) for all controls in >

RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-14 Thread Abhinay Agarwal
In Android, TextInputControls (TextField and TextArea) are responsible for showing and hiding software keyboard. Currently, a focus listener is attached to these controls and is used to toggle the visibility of keyboard. This condition fails in cases where the control already has focus but the ke

Re: [Rev 04] RFR: 8244112: Skin implementations: must not violate contract of dispose

2020-05-14 Thread Ajit Ghaisas
On Thu, 14 May 2020 10:11:16 GMT, Jeanette Winzenburg wrote: >> some skins have not been guarding themselves against multiple calls to >> dispose (see issue for details) >> >> Fixed by backing out off dispose if skinnable is null. Added test >> (parameterized in control class) for all control

Re: [Rev 04] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-05-14 Thread Frederic Thevenet
On Sat, 9 May 2020 17:28:52 GMT, Kevin Rushforth wrote: >> Frederic Thevenet has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert changes in import statements > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumT

Re: Questions ad JavaScript in JavaFX' WebEngine

2020-05-14 Thread Mike Hearn
The WebKit binding code is some of the more complex code in JavaFX. Rather than try to extend the script tag you could instead look at the code for the tag and the old support for Netscape-style plugins. https://github.com/openjdk/jfx/tree/master/modules/javafx.web/src/main/native/Source/WebCore/

Re: [Rev 04] RFR: 8244112: Skin implementations: must not violate contract of dispose

2020-05-14 Thread Ambarish Rapte
On Thu, 14 May 2020 10:11:16 GMT, Jeanette Winzenburg wrote: >> some skins have not been guarding themselves against multiple calls to >> dispose (see issue for details) >> >> Fixed by backing out off dispose if skinnable is null. Added test >> (parameterized in control class) for all control

Re: [Rev 04] RFR: 8244112: Skin implementations: must not violate contract of dispose

2020-05-14 Thread Jeanette Winzenburg
> some skins have not been guarding themselves against multiple calls to > dispose (see issue for details) > > Fixed by backing out off dispose if skinnable is null. Added test > (parameterized in control class) for all controls in > the controls package. Those that failed for the misbehaving sk

Re: [Rev 03] RFR: 8244112: Skin implementations: must not violate contract of dispose

2020-05-14 Thread Jeanette Winzenburg
On Thu, 14 May 2020 09:42:21 GMT, Ambarish Rapte wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added test for ContextMenu/Tooltip skin as requested in review > > modules/javafx.controls/src/test/java/test/

Re: [Rev 04] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-05-14 Thread Frederic Thevenet
On Mon, 11 May 2020 15:30:28 GMT, Nir Lisker wrote: >> Frederic Thevenet has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert changes in import statements > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolk

Re: [Rev 03] RFR: 8244112: Skin implementations: must not violate contract of dispose

2020-05-14 Thread Ambarish Rapte
On Thu, 14 May 2020 09:02:26 GMT, Jeanette Winzenburg wrote: >> some skins have not been guarding themselves against multiple calls to >> dispose (see issue for details) >> >> Fixed by backing out off dispose if skinnable is null. Added test >> (parameterized in control class) for all control

Re: [Rev 03] RFR: 8244112: Skin implementations: must not violate contract of dispose

2020-05-14 Thread Jeanette Winzenburg
> some skins have not been guarding themselves against multiple calls to > dispose (see issue for details) > > Fixed by backing out off dispose if skinnable is null. Added test > (parameterized in control class) for all controls in > the controls package. Those that failed for the misbehaving sk

Re: [Rev 01] RFR: 8244112: Skin implementations: must not violate contract of dispose

2020-05-14 Thread Jeanette Winzenburg
On Thu, 14 May 2020 04:44:38 GMT, Ambarish Rapte wrote: >> good catch :) >> >> Hmm .. thinking aloud: >> >> - all in web is a bit very different as a small layer on top of the >> webEngine, usually off my radar >> - the skinnable windows are no controls >> >> so the easy way out - which I wou

RFR: 8181775: JavaFX WebView does not calculate border-radius properly

2020-05-14 Thread Bhawesh Choudhary
root cause of issue is prism's fillRoundedRect() API doesn't allow rendering of rounded corner rectangle if four corners have different radii. but same can be achieved via Path. to fix the issue, in GraphicsContextJava.cpp while rendering fillRoundedRect, check if all four corners have same radii