RFR: 8245183: Two fxml unit tests log warnings about deprecated escape sequences

2020-05-19 Thread Ajit Ghaisas
Issue : https://bugs.openjdk.java.net/browse/JDK-8245183 Fix : Added a message to the test saying these are expected warnings. Refer JBS comments for more details. - Commit messages: - Add expected warning message Changes: https://git.openjdk.java.net/jfx/pull/225/files Webrev: ht

Re: RFR: 8244824: TableView : Incorrect German translation

2020-05-19 Thread Kevin Rushforth
On Tue, 19 May 2020 14:27:40 GMT, Ajit Ghaisas wrote: >> Correct :) > > @kevinrushforth brought to my notice that there is a PR > (https://github.com/openjdk/jfx/pull/210) opened for the same > issue by [schelldorfer](https://github.com/schelldorfer). I was not aware of > this PR as it did not

Re: RFR: 8244824: TableView : Incorrect German translation

2020-05-19 Thread Ajit Ghaisas
On Fri, 15 May 2020 09:47:09 GMT, Jeanette Winzenburg wrote: >> Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 >> >> Fix : As simple as it gets !!! > > Correct :) @kevinrushforth brought to my notice that there is a PR (https://github.com/openjdk/jfx/pull/210) opened for the same is

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
On Tue, 19 May 2020 09:23:38 GMT, Jeanette Winzenburg wrote: >> @kleopatra Done! > > wondering if there is any way to include android specific skins in unit > testing? For all (nearly, htmlEditor excluded > ;) others we have a test to guard against contract violations (and will soon > have tes

Re: RFR: 8245181: TreeTableViewTest > test_rt35039_resetRootChildren logs an exception

2020-05-19 Thread Kevin Rushforth
On Tue, 19 May 2020 10:29:12 GMT, Ajit Ghaisas wrote: >> Issue : https://bugs.openjdk.java.net/browse/JDK-8245181 >> >> Root cause : The exception just gets logged and does not result in test >> failure. >> >> Fix : Added the mechanism to catch and handle UncaughtException. Test >> test_rt350

RFR: 8245181: TreeTableViewTest > test_rt35039_resetRootChildren logs an exception

2020-05-19 Thread Ajit Ghaisas
Issue : https://bugs.openjdk.java.net/browse/JDK-8245181 Root cause : The exception just gets logged and does not result in test failure. Fix : Added the mechanism to catch and handle UncaughtException. Test test_rt35039_resetRootChildren fails with this mechanism. Fixed the test failure by addi

Re: RFR: 8245181: TreeTableViewTest > test_rt35039_resetRootChildren logs an exception

2020-05-19 Thread Ajit Ghaisas
On Tue, 19 May 2020 10:25:24 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8245181 > > Root cause : The exception just gets logged and does not result in test > failure. > > Fix : Added the mechanism to catch and handle UncaughtException. Test > test_rt35039_rese

Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus

Re: [Rev 04] RFR: 8218973: SVG with masking is not rendering image with mask effect

2020-05-19 Thread Bhawesh Choudhary
> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp > in WebKit was not implemented, so masking > doesn't take place at all while rendering SVGRect. to fix this issue add > implementation of function clipToImageBuffer() > in GraphicsContextJava.cpp and send clip image to

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Jeanette Winzenburg
On Tue, 19 May 2020 08:08:44 GMT, Abhinay Agarwal wrote: >> out off my home-zone here, just fyi and in case it might be relevant to >> android skins as well: there's an umbrella >> issue to cleanup skin implementations >> [JDK-8241364](https://bugs.openjdk.java.net/browse/JDK-8241364) - both t

Re: [Rev 01] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Jeanette Winzenburg
On Tue, 19 May 2020 08:10:40 GMT, Abhinay Agarwal wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard. This

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
On Fri, 15 May 2020 10:58:14 GMT, Jeanette Winzenburg wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard.

Re: [Rev 01] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus