Issue: Snapshot taken before webpage is rendered
Fix: Use stateProperty and sleep to wait for the page to finish rendering
-
Commit messages:
- Add sleep
- 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
Changes: https://git.openjdk.java.net/jfx/pull/240/files
W
On Thu, 28 May 2020 08:45:36 GMT, Arun Joseph wrote:
> Issue: Snapshot taken before webpage is rendered
>
> Fix: Use stateProperty and sleep to wait for the page to finish rendering
I tested it on my machine and it is running reliably for me now. I have a
couple suggestions below.
tests/syste
On Tue, 26 May 2020 21:12:07 GMT, Kevin Rushforth wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Tue, 26 May 2020 21:53:44 GMT, Kevin Rushforth wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Thu, 28 May 2020 15:16:03 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
>> 332:
>>
>>> 331: }
>>> 332: if (isNearZero(newRate)) {
>>> 333: if (isRunning()) {
>>
>> The code
On Thu, 28 May 2020 15:23:38 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
>> 402:
>>
>>> 401: */
>>> 402: private void doSetCurrentRate(double value) {
>>> 403: if (currentRate != null || !areNearEqual(value,
>>> DEFAULT_
> Mostly refactoring in preparation of the upcoming fixes. The changes might
> look like a lot, but it's mostly rearranging
> of methods. Summery of changes:
> ### Animation
> * Added `isNearZero` and `areNearEqual` methods that deal with `EPSILON`
> checks.
> * Added `isStopped`, `isRunning` and
On Thu, 28 May 2020 15:51:19 GMT, Kevin Rushforth wrote:
>> Doesn't the autogenerated JavaDoc for the `getX`, `setX` and `xProperty`
>> methods work by matching the method name to
>> the property name regardless of they location in the class?
>> `doSetCurrentRate` shouldn't ever be able to inte
On Thu, 28 May 2020 16:44:33 GMT, Nir Lisker wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal with
This is a fix for an intermittent test failure, due to a timeout, in
`SandboxAppTest` that we are starting to see on
some of our test machines.
The failure is happening because of a 10 second timeout in the launched
application. This doesn't seem to be enough to
run the test to completion in all
Looks like this is not a Catalina problem. It is a regression in openjfx
14 on macOS.
And it is caused by https://bugs.openjdk.java.net/browse/JDK-8234916
We have filed a new bug : https://bugs.openjdk.java.net/browse/JDK-8246104
-phil.
On 5/27/20, 9:00 AM, Abu Abdullah wrote:
On Wed, May 27,
On Fri, May 29, 2020 at 1:21 AM Philip Race wrote:
>
> Looks like this is not a Catalina problem. It is a regression in openjfx 14
> on macOS.
> And it is caused by https://bugs.openjdk.java.net/browse/JDK-8234916
I can see in the console this message:
CoreText note: Client requested name ".Arab
On Tue, 26 May 2020 13:41:15 GMT, Jeanette Winzenburg
wrote:
> Both skins have similar misbehavior when switching skins
>
> - memory leak due to a manually added but not removed change listener
> - NPE when modifying items after skin switch due to a not removed listener to
> the control's item
Ok. you said in the first post :
im using jfx 15-ea-5 on MacOS 10.15.3
Where did you get that build ?
-phil
On 5/28/20, 5:50 PM, Abu Abdullah wrote:
On Fri, May 29, 2020 at 1:21 AM Philip Race wrote:
Looks like this is not a Catalina problem. It is a regression in openjfx 14 on
macOS.
And
On Wed, 27 May 2020 06:51:41 GMT, Ajit Ghaisas wrote:
> This is a simple test fix.
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8245634
>
> After fixing [JDK-8245457,](https://bugs.openjdk.java.net/browse/JDK-8245457)
> I found that there are more ignored tests
> of similar nature that
On Fri, May 29, 2020 at 9:46 AM Philip Race wrote:
>
> Ok. you said in the first post :
>
> im using jfx 15-ea-5 on MacOS 10.15.3
>
> Where did you get that build ?
from maven
org.openjfx
javafx-controls
15-ea+5
mac
On Wed, 27 May 2020 06:51:41 GMT, Ajit Ghaisas wrote:
> This is a simple test fix.
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8245634
>
> After fixing [JDK-8245457,](https://bugs.openjdk.java.net/browse/JDK-8245457)
> I found that there are more ignored tests
> of similar nature that
17 matches
Mail list logo
