On Tue, 2 Jun 2020 21:01:05 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change isSortingInProgress to package scope
>
>
> Issue:
> In TreeTableView, in case of Multiple selection mode, if nested items are
> selected, then TreeTableView does not
> retain/update the selection correctly when the tree items are permuted(either
> by `sort()` or by reordering using
> `setAll()`). Cause:
>
> 1. For permutation, the
On Tue, 2 Jun 2020 21:08:27 GMT, Kevin Rushforth wrote:
> The algorithm looks correct to me for sorting. How much regression testing
> have you done for cases where rows or
> columns are inserted?
I have tested with a small TreeTableView of 15 rows of 3 levels and 3 columns.
Would it be enough
On Tue, 2 Jun 2020 21:00:27 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change isSortingInProgress to package scope
>
>
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev
wrote:
> - Updated libffi to 3.3.
This pull request has now been integrated.
Changeset: 6bd0e22d
Author:Alexander Matveev
URL: https://git.openjdk.java.net/jfx/commit/6bd0e22d
Stats: 10217 lines in 37 files changed: 4167 ins;
On Tue, 2 Jun 2020 18:02:50 GMT, Ambarish Rapte wrote:
>> Issue:
>> In TreeTableView, in case of Multiple selection mode, if nested items are
>> selected, then TreeTableView does not
>> retain/update the selection correctly when the tree items are
>> permuted(either by `sort()` or by
On Tue, 2 Jun 2020 17:52:37 GMT, Johan Vos wrote:
> add changes to build a static version of libjfxwebkit.a
> Fox for JDK-8246357
@arun-Joseph @guruhb can one of you also review?
-
PR: https://git.openjdk.java.net/jfx/pull/245
> Issue:
> In TreeTableView, in case of Multiple selection mode, if nested items are
> selected, then TreeTableView does not
> retain/update the selection correctly when the tree items are permuted(either
> by `sort()` or by reordering using
> `setAll()`). Cause:
>
> 1. For permutation, the
add changes to build a static version of libjfxwebkit.a
Fox for JDK-8246357
-
Commit messages:
- add changes to build a static version of libjfxwebkit.a
Changes: https://git.openjdk.java.net/jfx/pull/245/files
Webrev: https://webrevs.openjdk.java.net/jfx/245/webrev.00
Issue:
On Tue, 2 Jun 2020 17:00:28 GMT, Ambarish Rapte wrote:
> Issue:
> In TreeTableView, in case of Multiple selection mode, if nested items are
> selected, then TreeTableView does not
> retain/update the selection correctly when the tree items are permuted(either
> by `sort()` or by reordering
On Tue, 2 Jun 2020 17:00:28 GMT, Ambarish Rapte wrote:
> Issue:
> In TreeTableView, in case of Multiple selection mode, if nested items are
> selected, then TreeTableView does not
> retain/update the selection correctly when the tree items are permuted(either
> by `sort()` or by reordering
Issue:
In TreeTableView, in case of Multiple selection mode, if nested items are
selected, then TreeTableView does not
retain/update the selection correctly when the tree items are permuted(either
by `sort()` or by reordering using
`setAll()`).
Cause:
1. For permutation, the current
Vote: YES
— Arun Joseph
> On 01-Jun-2020, at 7:22 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Jeanette Winzenburg [1] to OpenJFX Committer.
>
> Jeanette is an OpenJFX community member, who has contributed 16 changesets
> [2][3] to OpenJFX.
>
> Votes are due by June 15, 2020.
>
>
Vote: YES
— Arun Joseph
> On 01-Jun-2020, at 7:23 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Jose Pereda [1] to OpenJFX Committer.
>
> Jose is an OpenJFX community member, who has contributed 16 changesets [2][3]
> to OpenJFX.
>
> Votes are due by June 15, 2020.
>
> Only current
On Wed, 20 May 2020 11:15:34 GMT, Jeanette Winzenburg
wrote:
> Reason for the memory leak is a listener on control's focusProperty that is
> not correctly removed on dispose. For
> details please see the report.
> Added a test method to ButtonSkinTest that failed before and passes after the
>
Vote: YES
Vote: YES
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev
wrote:
> - Updated libffi to 3.3.
Looks good to me.
-
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/242
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev
wrote:
> - Updated libffi to 3.3.
I tested this and couldn't find issues. The uncommented line worries me a bit,
though, but I can't see a reason why it
should be commented again.
-
Marked as reviewed by jvos (Reviewer).
PR:
On Fri, 24 Apr 2020 00:58:30 GMT, Nir Lisker wrote:
> Mostly refactoring in preparation of the upcoming fixes. The changes might
> look like a lot, but it's mostly rearranging
> of methods. Summery of changes:
> ### Animation
> * Added `isNearZero` and `areNearEqual` methods that deal with
On Wed, 27 May 2020 10:26:25 GMT, Jeanette Winzenburg
wrote:
>> Reason for the memory leak is a listener on control's focusProperty that is
>> not correctly removed on dispose. For
>> details please see the report.
>> Added a test method to ButtonSkinTest that failed before and passes after
21 matches
Mail list logo
