On Tue, 2 Jun 2020 17:31:52 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> kcr review comment changes
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java
> lin
On Wed, 3 Jun 2020 05:15:34 GMT, Ambarish Rapte wrote:
>> The algorithm looks correct to me for sorting. How much regression testing
>> have you done for cases where rows or
>> columns are inserted?
>> I left a few comments, and will complete my testing in parallel.
>
>> The algorithm looks corr
On Wed, 3 Jun 2020 12:03:43 GMT, Jeanette Winzenburg
wrote:
>>> The algorithm looks correct to me for sorting. How much regression testing
>>> have you done for cases where rows or
>>> columns are inserted?
>>
>> I have tested with a small TreeTableView of 15 rows of 3 levels and 3
>> columns
On Wed, 3 Jun 2020 12:03:43 GMT, Jeanette Winzenburg
wrote:
>>> The algorithm looks correct to me for sorting. How much regression testing
>>> have you done for cases where rows or
>>> columns are inserted?
>>
>> I have tested with a small TreeTableView of 15 rows of 3 levels and 3
>> columns
I hereby nominate Nir Lisker [1] to OpenJFX Reviewer.
Nir is an OpenJFX community member, who has contributed 29 changesets
[2][3] to OpenJFX over the course of the past 2 years. Nir consistently
participates in code reviews of various OpenJFX pull requests, and has
become proficient in the ar
Vote: YES
On 6/3/2020 6:28 AM, Kevin Rushforth wrote:
I hereby nominate Nir Lisker [1] to OpenJFX Reviewer.
On Tue, 2 Jun 2020 18:01:40 GMT, Kevin Rushforth wrote:
>> add changes to build a static version of libjfxwebkit.a
>> Fox for JDK-8246357
>
> @arun-Joseph @guruhb can one of you also review?
The diffs look good. I'm doing test builds now.
-
PR: https://git.openjdk.java.net/jfx/pull
On Wed, 3 Jun 2020 05:15:34 GMT, Ambarish Rapte wrote:
> I have tested with a small TreeTableView of 15 rows of 3 levels and 3 columns.
> Would it be enough to test with TreeTableView of ~500 rows of 5 levels, 10
> columns ?
>
> Update: I am testing with 7 level of nested rows, with 10, 9, 7, 6
Vote: yes.
-phil.
On Tue, 2 Jun 2020 17:52:37 GMT, Johan Vos wrote:
> add changes to build a static version of libjfxwebkit.a
> Fox for JDK-8246357
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/245
On Mon, 1 Jun 2020 17:52:46 GMT, Michael Paus wrote:
> It seems to be sufficient to add "intel" as an additional vendor to the list
> in the X11GLFactory class. Tests pass and
> my own application also works with the new build.
modules/javafx.graphics/src/main/java/com/sun/prism/es2/X11GLFactor
On Tue, 2 Jun 2020 17:52:37 GMT, Johan Vos wrote:
> add changes to build a static version of libjfxwebkit.a
> Fox for JDK-8246357
Changes looks good to me.
-
Marked as reviewed by ajoseph (Committer).
PR: https://git.openjdk.java.net/jfx/pull/245
12 matches
Mail list logo
