Integrated: 8208169: can not print selected pages of web page

2020-06-17 Thread Bhawesh Choudhary
On Fri, 15 May 2020 16:36:29 GMT, Bhawesh Choudhary wrote: > Print function of WebEngine.java ignores page range setting and prints given > number of pages starting from first page, > which is the root cause of this issue. To fix it, put check for page ranges > and if it available, use it for

Re: RFR: 8208169: can not print selected pages of web page [v5]

2020-06-17 Thread Phil Race
On Tue, 16 Jun 2020 07:59:02 GMT, Bhawesh Choudhary wrote: >> Print function of WebEngine.java ignores page range setting and prints given >> number of pages starting from first page, >> which is the root cause of this issue. To fix it, put check for page ranges >> and if it available, use it

Integrated: 8247163: JFXPanel throws exception on click when no Scene is set

2020-06-17 Thread Florian Kirmaier
On Tue, 9 Jun 2020 10:39:29 GMT, Florian Kirmaier wrote: > Fixing exception when clicking on JFXPanel when no Scene is set. > > quick test: `./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests: test > --tests *javafx.embed.swing.JFXPan* --info` > > It's a regression from my previous PR: h

Result: New OpenJFX Reviewer: Nir Lisker

2020-06-17 Thread Kevin Rushforth
Voting for Nir Lisker [1] to OpenJFX Reviewer [2] is now closed. Yes: 5 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. -- Kevin [1] https://openjdk.java.net/census#nlisker [2] https://mail.openjdk.java.net/piperma

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v11]

2020-06-17 Thread Frederic Thevenet
> Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be > larger than the running platform's maximum supported texture size, was > addressed in openjfx14. The fix, based around > the idea of capturing as many tiles of the maximum

Re: RFR: 8247163: JFXPanel throws exception on click when no Scene is set [v2]

2020-06-17 Thread Kevin Rushforth
On Tue, 16 Jun 2020 07:34:13 GMT, Florian Kirmaier wrote: >> Fixing exception when clicking on JFXPanel when no Scene is set. >> >> quick test: `./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests: test >> --tests *javafx.embed.swing.JFXPan* --info` >> >> It's a regression from my previo

Re: RFR: 8193800: TreeTableView selection changes on sorting [v4]

2020-06-17 Thread Kevin Rushforth
On Wed, 17 Jun 2020 11:46:07 GMT, Ambarish Rapte wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java >> line 472: >> >>> 471: countSelectedIndexChangeEvent++; >>> 472: assertEquals(selectedItemBefore, >>> treeTableView.getTre

Re: RFR: 8193800: TreeTableView selection changes on sorting [v5]

2020-06-17 Thread Kevin Rushforth
On Wed, 17 Jun 2020 11:38:45 GMT, Ambarish Rapte wrote: >> Issue: >> In TreeTableView, in case of Multiple selection mode, if nested items are >> selected, then TreeTableView does not >> retain/update the selection correctly when the tree items are >> permuted(either by `sort()` or by reorderin

Re: [Rev 04] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-06-17 Thread Frederic Thevenet
On Mon, 15 Jun 2020 15:55:25 GMT, Frederic Thevenet wrote: >> Overall, this looks quite good. In particular the tiled rendering, as >> implemented by the `renderTile` method, should be >> reasonably efficient. >> My only high-level comment is that I'm somewhat skeptical of >> `computeOptimumTi

Re: [Rev 09] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-06-17 Thread Frederic Thevenet
> Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be > larger than the running platform's maximum supported texture size, was > addressed in openjfx14. The fix, based around > the idea of capturing as many tiles of the maximum

Re: [Rev 03] RFR: 8193800: TreeTableView selection changes on sorting

2020-06-17 Thread Ambarish Rapte
On Mon, 15 Jun 2020 23:41:08 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Correcting the selection change events generated post sorting > > modules/javafx.controls/src/test/java/test/javaf

Re: [Rev 03] RFR: 8193800: TreeTableView selection changes on sorting

2020-06-17 Thread Ambarish Rapte
On Mon, 15 Jun 2020 23:26:33 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Correcting the selection change events generated post sorting > > modules/javafx.controls/src/main/java/javafx/sce

Re: [Rev 04] RFR: 8193800: TreeTableView selection changes on sorting

2020-06-17 Thread Ambarish Rapte
> Issue: > In TreeTableView, in case of Multiple selection mode, if nested items are > selected, then TreeTableView does not > retain/update the selection correctly when the tree items are permuted(either > by `sort()` or by reordering using > `setAll()`). Cause: > > 1. For permutation, the cur

Re: [Rev 08] RFR: 8238954: Improve performance of tiled snapshot rendering

2020-06-17 Thread Frederic Thevenet
> Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be > larger than the running platform's maximum supported texture size, was > addressed in openjfx14. The fix, based around > the idea of capturing as many tiles of the maximum

Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175%

2020-06-17 Thread Prasanta Sadhukhan
On Wed, 3 Jun 2020 15:46:36 GMT, Oliver Schmidtmer wrote: > In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and > Math.round produce different results and > EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one error > on the line width and therefore

Re: 11-dev backport request: JDK-8247360: Add missing license file for Microsoft DirectShow Samples

2020-06-17 Thread Johan Vos
approved On Wed, Jun 17, 2020 at 1:58 AM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the following to 11-dev for 11.0.8: > > JDK-8247360 [1] : Add missing license file for Microsoft DirectShow Samples > > -- Kevin > > [1] https://bugs.openjdk.java.net/browse/JDK-8247360