Integrated: 8193800: TreeTableView selection changes on sorting

2020-06-28 Thread Ambarish Rapte
On Tue, 2 Jun 2020 17:00:28 GMT, Ambarish Rapte wrote: > Issue: > In TreeTableView, in case of Multiple selection mode, if nested items are > selected, then TreeTableView does not > retain/update the selection correctly when the tree items are permuted(either > by `sort()` or by reordering usin

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v6]

2020-06-28 Thread Ajit Ghaisas
On Sat, 27 Jun 2020 14:07:24 GMT, Rony G. Flatscher wrote: >> This PR adds a "compile" process instruction to FXML files with the optional >> PI data "true" (default) and "false". The >> PI data is turned into a boolean value using "Boolean.parseBoolean(String)". >> This makes it possible to in

Re: RFR: 8193800: TreeTableView selection changes on sorting [v7]

2020-06-28 Thread Ajit Ghaisas
On Fri, 26 Jun 2020 09:22:53 GMT, Ambarish Rapte wrote: >> Issue: >> In TreeTableView, in case of Multiple selection mode, if nested items are >> selected, then TreeTableView does not >> retain/update the selection correctly when the tree items are >> permuted(either by `sort()` or by reorderin

Re: RFR: 8240264: iOS: Unnecessary logging on every pulse when GL context changes [v3]

2020-06-28 Thread Johan Vos
On Sun, 28 Jun 2020 18:34:01 GMT, Jose Pereda wrote: >> This PR comments out too verbose console logging, as it has been done with >> some other fprintf calls. >> As a follow up of this PR, a custom directive that enables this output if >> needed can be considered. > > Jose Pereda has updated t

Re: RFR: 8240264: iOS: Unnecessary logging on every pulse when GL context changes [v2]

2020-06-28 Thread Jose Pereda
On Mon, 15 Jun 2020 19:52:26 GMT, Jose Pereda wrote: >> modules/javafx.graphics/src/main/native-prism-es2/ios/IOSWindowSystemInterface.m >> line 86: >> >>> 85: if (pulseLoggingRequested) { >>> 86: fprintf(stderr, "IOSWindowSystemInterface : deleteContext >>> unimp\n"); >>> 87:

Re: RFR: 8240264: iOS: Unnecessary logging on every pulse when GL context changes [v3]

2020-06-28 Thread Jose Pereda
> This PR comments out too verbose console logging, as it has been done with > some other fprintf calls. > As a follow up of this PR, a custom directive that enables this output if > needed can be considered. Jose Pereda has updated the pull request incrementally with one additional commit sinc

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v6]

2020-06-28 Thread Rony G . Flatscher
On Sat, 27 Jun 2020 14:41:29 GMT, Kevin Rushforth wrote: >> Rony G. Flatscher has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Incorporating Kevin's review comments (overlooked some places). > > Looks good. It seems that there is a need