Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v4]

2020-07-07 Thread Oliver Schmidtmer
On Mon, 6 Jul 2020 23:31:28 GMT, Kevin Rushforth wrote: >> build.gradle line 3611: >> >>> 3610: testCompile project(":swt") >>> 3611: testCompile name: SWT_FILE_NAME >>> 3612: } >> >> We can't have a dependency on `swt` from any other project. SWT tests need >> to be confin

Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v5]

2020-07-07 Thread Oliver Schmidtmer
> In edge cases where monitor scaling of 1.25 or 1.75 is active, Math.ceil and > Math.round produce different results and > EmbeddedScene#getPixels in JFXPanel#paintComponent causes an off-by-one error > on the line width and therefore sheared > rendering. The changes were already proposed by th

Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v4]

2020-07-07 Thread Oliver Schmidtmer
On Mon, 6 Jul 2020 18:00:08 GMT, Kevin Rushforth wrote: >> Oliver Schmidtmer has refreshed the contents of this pull request, and >> previous commits have been removed. The >> incremental views will show differences compared to the previous content of >> the PR. > > tests/system/src/test/java/t

Re: RFR: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175% [v4]

2020-07-07 Thread Oliver Schmidtmer
On Mon, 6 Jul 2020 18:18:20 GMT, Kevin Rushforth wrote: >> Oliver Schmidtmer has refreshed the contents of this pull request, and >> previous commits have been removed. The >> incremental views will show differences compared to the previous content of >> the PR. > > tests/system/src/test/java/t