[jfx14] Integrated: 8249635: Change JavaFX release version in jfx14 branch to 14.0.2.1

2020-07-16 Thread Johan Vos
On Thu, 16 Jul 2020 20:16:54 GMT, Johan Vos wrote: > Set the patch version for JavaFX 14.0.2.1 > Fix for JDK-8249635 This pull request has now been integrated. Changeset: dac82880 Author:Johan Vos URL: https://git.openjdk.java.net/jfx/commit/dac82880 Stats: 1 line in 1 file

[jfx14] RFR: 8249635: Change JavaFX release version in jfx14 branch to 14.0.2.1

2020-07-16 Thread Johan Vos
Set the patch version for JavaFX 14.0.2.1 Fix for JDK-8249635 - Commit messages: - set patch version to 1 for the upcoming 14.0.2.1 release Changes: https://git.openjdk.java.net/jfx/pull/267/files Webrev: https://webrevs.openjdk.java.net/jfx/267/webrev.00 Issue:

Re: [jfx14] RFR: 8249635: Change JavaFX release version in jfx14 branch to 14.0.2.1

2020-07-16 Thread Kevin Rushforth
On Thu, 16 Jul 2020 20:16:54 GMT, Johan Vos wrote: > Set the patch version for JavaFX 14.0.2.1 > Fix for JDK-8249635 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/267

Integrated: 8248908: Printer.createPageLayout() returns 0.75" margins instead of hardware margins

2020-07-16 Thread Phil Race
On Wed, 15 Jul 2020 23:54:59 GMT, Phil Race wrote: > For a Media that had no defined size - eg a "custom" paper - the code was > creating a mapping > that over-rode the NA_LETTER size. This might cause multiple problems but > definitely meant that > we ended up with default margins. This pull

Integrated: 8245284: Update to 610.1 version of WebKit

2020-07-16 Thread Arun Joseph
On Fri, 10 Jul 2020 05:26:39 GMT, Arun Joseph wrote: > Update JavaFX WebKit to GTK WebKit 2.28 (610.1) This pull request has now been integrated. Changeset: 5e7e452c Author:Arun Joseph URL: https://git.openjdk.java.net/jfx/commit/5e7e452c Stats: 300855 lines in 5370 files

Re: RFR: 8248908: Printer.createPageLayout() returns 0.75" margins instead of hardware margins [v2]

2020-07-16 Thread Phil Race
> For a Media that had no defined size - eg a "custom" paper - the code was > creating a mapping > that over-rode the NA_LETTER size. This might cause multiple problems but > definitely meant that > we ended up with default margins. Phil Race has updated the pull request incrementally with one

Re: RFR: 8248908: Printer.createPageLayout() returns 0.75" margins instead of hardware margins [v2]

2020-07-16 Thread Kevin Rushforth
On Thu, 16 Jul 2020 18:39:46 GMT, Phil Race wrote: >> For a Media that had no defined size - eg a "custom" paper - the code was >> creating a mapping >> that over-rode the NA_LETTER size. This might cause multiple problems but >> definitely meant that >> we ended up with default margins. > >

Re: RFR: 8245284: Update to 610.1 version of WebKit

2020-07-16 Thread Joeri Sykora
On Fri, 10 Jul 2020 05:26:39 GMT, Arun Joseph wrote: > Update JavaFX WebKit to GTK WebKit 2.28 (610.1) Successfully tested building on all three platforms. - Marked as reviewed by sykora (Author). PR: https://git.openjdk.java.net/jfx/pull/263

Re: Request for permission to backport to 14

2020-07-16 Thread Kevin Rushforth
+1 -- Kevin On 7/16/2020 11:10 AM, Johan Vos wrote: Hi Kevin, I request permission to backport the following fixes to the jfx14 branch: JDK-8244579: Windows "User Objects" leakage with WebView JDK-8237889: Update libxml2 to version 2.9.10 JDK-8239107: Update libjpeg to version 9d

Request for permission to backport to 14

2020-07-16 Thread Johan Vos
Hi Kevin, I request permission to backport the following fixes to the jfx14 branch: JDK-8244579: Windows "User Objects" leakage with WebView JDK-8237889: Update libxml2 to version 2.9.10 JDK-8239107: Update libjpeg to version 9d JDK-8236832: [macos 10.15] JavaFX Application hangs on video play

Re: RFR: 8248908: Printer.createPageLayout() returns 0.75"margins instead of hardware margins

2020-07-16 Thread Kevin Rushforth
On Wed, 15 Jul 2020 23:54:59 GMT, Phil Race wrote: > For a Media that had no defined size - eg a "custom" paper - the code was > creating a mapping > that over-rode the NA_LETTER size. This might cause multiple problems but > definitely meant that > we ended up with default margins. Fix looks

Re: RFR: 8248908: Printer.createPageLayout() returns 0.75"margins instead of hardware margins

2020-07-16 Thread Dan Howard
I don't think the private method needs to be final. Does  it? On 7/15/2020 8:11 PM, Phil Race wrote: For a Media that had no defined size - eg a "custom" paper - the code was creating a mapping that over-rode the NA_LETTER size. This might cause multiple problems but definitely meant that we