Re: RFR: 8245181: TreeTableViewTest > test_rt35039_resetRootChildren logs an exception

2020-07-23 Thread Ajit Ghaisas
On Thu, 23 Jul 2020 17:53:24 GMT, Kevin Rushforth wrote: >> I completed the work with an incorrect branch name. I will continue using >> this branch only for this fix. > > @aghaisas Is this PR still relevant? If not, then go ahead and close it. This test does not throw exception anymore after J

Withdrawn: 8245181: TreeTableViewTest > test_rt35039_resetRootChildren logs an exception

2020-07-23 Thread Ajit Ghaisas
On Tue, 19 May 2020 10:25:24 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8245181 > > Root cause : The exception just gets logged and does not result in test > failure. > > Fix : Added the mechanism to catch and handle UncaughtException. Test > test_rt35039_rese

Re: [jfx15] RFR: 8250238: Media fails to load libav 58 library when using modules from maven central

2020-07-23 Thread Alexander Matveev
On Thu, 23 Jul 2020 21:40:05 GMT, Kevin Rushforth wrote: > When running a JavaFX application using the JavaFX modules from maven > central, the native libraries are packed into the > jar file, and then unpacked as needed by the JavaFX runtime. This fails for > libavplugin-ffmpeg-58.so, because

Re: [jfx15] RFR: 8250238: Media fails to load libav 58 library when using modules from maven central

2020-07-23 Thread Alexander Matveev
On Thu, 23 Jul 2020 21:44:22 GMT, Kevin Rushforth wrote: >> NOTE: This is targeted to `jfx15`. As such I would like a second reviewer. > > @sashamatveev can you review? > > @tiainen or @johanvos can one of you review as well? Looks good. - PR: https://git.openjdk.java.net/jfx/pull

Re: [jfx15] RFR: 8250238: Media fails to load libav 58 library when using modules from maven central

2020-07-23 Thread Kevin Rushforth
On Thu, 23 Jul 2020 21:40:52 GMT, Kevin Rushforth wrote: >> When running a JavaFX application using the JavaFX modules from maven >> central, the native libraries are packed into the >> jar file, and then unpacked as needed by the JavaFX runtime. This fails for >> libavplugin-ffmpeg-58.so, beca

[jfx15] RFR: 8250238: Media fails to load libav 58 library when using modules from maven central

2020-07-23 Thread Kevin Rushforth
When running a JavaFX application using the JavaFX modules from maven central, the native libraries are packed into the jar file, and then unpacked as needed by the JavaFX runtime. This fails for libavplugin-ffmpeg-58.so, because the entry for the `avplugin-ffmpeg-58` library is missing from the

Re: [jfx15] RFR: 8250238: Media fails to load libav 58 library when using modules from maven central

2020-07-23 Thread Kevin Rushforth
On Thu, 23 Jul 2020 21:40:05 GMT, Kevin Rushforth wrote: > When running a JavaFX application using the JavaFX modules from maven > central, the native libraries are packed into the > jar file, and then unpacked as needed by the JavaFX runtime. This fails for > libavplugin-ffmpeg-58.so, because

Re: RFR: [WIP]8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing

2020-07-23 Thread Kevin Rushforth
On Sat, 11 Apr 2020 09:53:46 GMT, Ambarish Rapte wrote: > The issue occurs because the key events are consumed by the `ListView` in > `Popup`, which displays the items. > This is a regression of > [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change > aadded several > `

Re: RFR: 8245181: TreeTableViewTest > test_rt35039_resetRootChildren logs an exception

2020-07-23 Thread Kevin Rushforth
On Tue, 19 May 2020 10:29:12 GMT, Ajit Ghaisas wrote: >> Issue : https://bugs.openjdk.java.net/browse/JDK-8245181 >> >> Root cause : The exception just gets logged and does not result in test >> failure. >> >> Fix : Added the mechanism to catch and handle UncaughtException. Test >> test_rt350

Re: RFR: 8244297: memory leak test utility [v4]

2020-07-23 Thread Kevin Rushforth
On Tue, 21 Jul 2020 12:27:05 GMT, Florian Kirmaier wrote: >> The createGarbage method stimulates the GC. All unit tests are green without >> it, but according to my memory some tests >> in an earlier version of this library were unstable without this. I can also >> change the configuration to

Re: RFR: 8169501: GIF animation is too fast

2020-07-23 Thread Kevin Rushforth
On Fri, 15 May 2020 07:42:40 GMT, Bhawesh Choudhary wrote: > issue is caused by the threshold value for frame duration used by javaFx > before it gets normalized. JavaFx is using > threshold value 10 while other browser (Safari, Firefox) is using 50 due to > which, value between 10 and 50 don'

Re: RFR: 8249777: build.gradle: project.version should not contain time stamps [v2]

2020-07-23 Thread Joeri Sykora
On Thu, 23 Jul 2020 13:45:33 GMT, Kevin Rushforth wrote: >> The addMavenPublication method sets the `project.version` to >> `$MAVEN_VERSION`, where project is base, graphics, >> controls, etc. When doing an ordinary "developer" build, this property >> contains the time stamp . This is causing >

Re: RFR: 8249839: Cherry pick GTK WebKit 2.28.3 changes

2020-07-23 Thread Kevin Rushforth
On Thu, 23 Jul 2020 05:34:50 GMT, Arun Joseph wrote: > Update to GTK WebKit 2.28.3 > https://webkitgtk.org/2020/07/09/webkitgtk2.28.3-released.html Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/271

Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-23 Thread Kevin Rushforth
The proposed fix will be to disable the maven publishing tasks by default, and to not set the project.version at all. So this will decouple the maven publishing tasks, and they won't interfere with normal developer or production builds. Joeri or Johan can confirm, but if they ever do upload a

Fullscreen canvas

2020-07-23 Thread Davide Perini
Hi all, is it possible to create a fullscreen canvas? I don't find a good doc for JavaFX and canvas. Thanks Davide

Re: RFR: 8249777: build.gradle: project.version should not contain time stamps [v2]

2020-07-23 Thread Kevin Rushforth
> The addMavenPublication method sets the `project.version` to > `$MAVEN_VERSION`, where project is base, graphics, > controls, etc. When doing an ordinary "developer" build, this property > contains the time stamp . This is causing > problems with the NetBeans gradle plugin not being able to det

Re: Re: Fixing NetBeans Gradle Support for OpenJFX

2020-07-23 Thread Eric Bresie
Is there a need for some further cleanup dependency between builds maybe to remove duplicate jars / modules with different time stamps? Rather than time stamp in these cases should it just use a SNAPSHOT designation instead? Eric Bresie ebre...@gmail.com > On July 20, 2020 at 5:42:30 PM CDT, Ke

Re: RFR: 8249777: build.gradle: project.version should not contain time stamps

2020-07-23 Thread Joeri Sykora
On Wed, 22 Jul 2020 17:24:24 GMT, Kevin Rushforth wrote: >> The addMavenPublication method sets the `project.version` to >> `$MAVEN_VERSION`, where project is base, graphics, >> controls, etc. When doing an ordinary "developer" build, this property >> contains the time stamp . This is causing >

Re: [jfx15] RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread [v2]

2020-07-23 Thread Kevin Rushforth
On Thu, 23 Jul 2020 12:34:43 GMT, Eric Bresie wrote: >> Marked as reviewed by arapte (Reviewer). > > Just curious and this may be OBE by now but... I see the check thread but > when accessing the buffer itself, should it > have some sort of synchronization of some type to make it more thread

Re: [jfx15] RFR: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread [v2]

2020-07-23 Thread Eric Bresie
On Fri, 10 Jul 2020 05:20:03 GMT, Ambarish Rapte wrote: >> John Neffenger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove assert statements > > Marked as reviewed by arapte (Reviewer). Just curious and this may be OBE by now but.

Re: RFR: 8181775: JavaFX WebView does not calculate border-radius properly [v4]

2020-07-23 Thread Kevin Rushforth
On Fri, 15 May 2020 17:33:10 GMT, Kevin Rushforth wrote: >> Bhawesh Choudhary has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now >> contains four commits: >> - Merge branch 'master' into 8181775 >> - Removed wildcard import statement >> - F

Re: RFR: 8181775: JavaFX WebView does not calculate border-radius properly [v4]

2020-07-23 Thread Bhawesh Choudhary
> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering > of rounded corner rectangle if four > corners have different radii. but same can be achieved via Path. to fix the > issue, in GraphicsContextJava.cpp while > rendering fillRoundedRect, check if all four corners have