Re: [jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v3]

2020-07-30 Thread Nir Lisker
> This was missed the in Javadoc fixes for 15. > > Added documentation for all the constructors, did a bit of formatting, and > removed redundant comments. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Corrected NumberFormat constru

JavaFX 15 is in Rampdown Phase Two (RDP2)

2020-07-30 Thread Kevin Rushforth
To: OpenJFX Developers As a reminder, JavaFX 15 is now in Rampdown Phase Two (RDP2). [1] P1-P2 bugs, and test or doc bugs of any priority, can be fixed during RDP2. Explicit approval is needed for bug fixes (except for doc and test fixes), and all enhancements to go in to the jfx15 branch. The

Re: Deadlock: JFXPanel, ContextMenu, macOS

2020-07-30 Thread Kevin Rushforth
Thanks, I'll take a look at it and let you know if we need anything else. -- Kevin On 7/30/2020 8:45 AM, Steven Yi wrote: Hi Kevin, I pasted in the minimal reproducible example with the issue I filed as well as a link to the github repo; I hope the everything is in order. Thanks, Steven

Re: Deadlock: JFXPanel, ContextMenu, macOS

2020-07-30 Thread Steven Yi
Hi Kevin, I pasted in the minimal reproducible example with the issue I filed as well as a link to the github repo; I hope the everything is in order. Thanks, Steven On Thu, Jul 30, 2020 at 10:57 AM Kevin Rushforth wrote: > If you can provide a small, standalone test case as part of the bug >

Re: Deadlock: JFXPanel, ContextMenu, macOS

2020-07-30 Thread Kevin Rushforth
If you can provide a small, standalone test case as part of the bug report, that would be ideal. Thanks. -- Kevin On 7/30/2020 6:46 AM, Steven Yi wrote: Hi Michael, Thanks for the link, I missed that when I went to explore JBS. I'll report the issue there. All best, Steven On Thu, Jul 30

Re: Deadlock: JFXPanel, ContextMenu, macOS

2020-07-30 Thread Steven Yi
Hi Michael, Thanks for the link, I missed that when I went to explore JBS. I'll report the issue there. All best, Steven On Thu, Jul 30, 2020 at 3:25 AM Michael Paus wrote: > Hi Steven, > the right place for bug reports like this is here: > > Michael > > A

Re: [jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors [v2]

2020-07-30 Thread Nir Lisker
> This was missed the in Javadoc fixes for 15. > > Added documentation for all the constructors, did a bit of formatting, and > removed redundant comments. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Added note on immutability --

Integrated: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-07-30 Thread Abhinay Agarwal
On Thu, 14 May 2020 19:22:54 GMT, Abhinay Agarwal wrote: > In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > c

Re: Deadlock: JFXPanel, ContextMenu, macOS

2020-07-30 Thread Michael Paus
Hi Steven, the right place for bug reports like this is here: Michael Am 30.07.20 um 01:28 schrieb Steven Yi: Hi All, I'm not sure if this is the place to report this, but hopefully so. (I did not see a way to create an account or report issues on JBS.) I

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v3]

2020-07-30 Thread Ambarish Rapte
On Thu, 23 Jul 2020 17:57:34 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - revert unintended line deletion >> - changes to address to review > > Once the merge conflicts and review comme

Re: RFR: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing [v3]

2020-07-30 Thread Ambarish Rapte
> The issue occurs because the key events are consumed by the `ListView` in > `Popup`, which displays the items. > This is a regression of > [JDK-8077916](https://bugs.openjdk.java.net/browse/JDK-8077916). This change > aadded several > `KeyMapping`s for focus traversals to `ListView`, which con